New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes and improvments for config dialog #432

merged 3 commits into from Dec 10, 2018


None yet
3 participants
Copy link

rdoeffinger commented Nov 4, 2018

  • Fix endless append of / at end of password store path on Windows
  • When the user is told to fix the binaries configuration, send the straight to the proper tab to fix it
  • Add an autodetect button for the programs, so that if the user forgot to install dependencies onfirst start they don't have to fill everything in manually once they did.

rdoeffinger added some commits Aug 29, 2018

Fix incorrect use of / as path separator.
This fixes the password store path growing an endless
set of / at the end on Windows.
Also disable delete and edit buttons when entry is deselected.
Show Programs tab in config dialog if config is broken.
It is confusing to show a tab that has nothing to do
with the problem the user needs to fix.
Add autodetect button for programs.
Makes it easy for user to reset the values
to the defaults.

This comment has been minimized.

Copy link

codecov bot commented Nov 4, 2018

Codecov Report

Merging #432 into master will decrease coverage by 0.04%.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #432      +/-   ##
- Coverage    7.25%   7.2%   -0.05%     
  Files          41     41              
  Lines        2662   2678      +16     
  Hits          193    193              
- Misses       2469   2485      +16
Impacted Files Coverage Δ
src/configdialog.h 0% <ø> (ø) ⬆️
src/mainwindow.cpp 0% <0%> (ø) ⬆️
src/configdialog.cpp 0% <0%> (ø) ⬆️
src/qtpasssettings.cpp 7.57% <0%> (ø) ⬆️
src/util.cpp 8.62% <0%> (-0.16%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32ea1ad...7f8136e. Read the comment docs.


This comment has been minimized.

Copy link

coveralls commented Nov 4, 2018

Coverage Status

Coverage decreased (-0.04%) to 7.216% when pulling 7f8136e on rdoeffinger:configfixes into 32ea1ad on IJHack:master.

@annejan annejan merged commit bba04e0 into IJHack:master Dec 10, 2018

3 of 5 checks passed

codecov/patch 0% of diff hit (target 7.25%)
codecov/project 7.2% (-0.05%) compared to 32ea1ad
CodeFactor No issues found.
continuous-integration/appveyor/pr AppVeyor build succeeded
continuous-integration/travis-ci/pr The Travis CI build passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment