Fixes and improvments for config dialog #432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rdoeffinger
commented
Nov 4, 2018
rdoeffinger
commented
- Fix endless append of / at end of password store path on Windows
- When the user is told to fix the binaries configuration, send the straight to the proper tab to fix it
- Add an autodetect button for the programs, so that if the user forgot to install dependencies onfirst start they don't have to fill everything in manually once they did.
This fixes the password store path growing an endless set of / at the end on Windows. Also disable delete and edit buttons when entry is deselected.
It is confusing to show a tab that has nothing to do with the problem the user needs to fix.
Makes it easy for user to reset the values to the defaults.
Codecov Report
@@ Coverage Diff @@
## master #432 +/- ##
========================================
- Coverage 7.25% 7.2% -0.05%
========================================
Files 41 41
Lines 2662 2678 +16
========================================
Hits 193 193
- Misses 2469 2485 +16
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.