Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For config check, check that the selected binary is available. #438

Merged
merged 1 commit into from Dec 17, 2018

Conversation

Projects
None yet
3 participants
@rdoeffinger
Copy link
Contributor

commented Dec 12, 2018

pass being available is irrelevant if QtPass was configured to
use gpg for example.

For config check, check that the selected binary is available.
pass being available is irrelevant if QtPass was configured to
use gpg for example.
@codecov

This comment has been minimized.

Copy link

commented Dec 12, 2018

Codecov Report

Merging #438 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #438      +/-   ##
=========================================
- Coverage    7.23%   7.23%   -0.01%     
=========================================
  Files          41      41              
  Lines        2721    2722       +1     
=========================================
  Hits          197     197              
- Misses       2524    2525       +1
Impacted Files Coverage Δ
src/util.cpp 8.19% <0%> (-0.14%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3b41ae...2f39223. Read the comment docs.

@coveralls

This comment has been minimized.

Copy link

commented Dec 12, 2018

Coverage Status

Coverage decreased (-0.06%) to 7.255% when pulling 2f39223 on rdoeffinger:checkconfig into f3b41ae on IJHack:master.

@annejan annejan merged commit c237352 into IJHack:master Dec 17, 2018

3 of 5 checks passed

codecov/patch 0% of diff hit (target 7.23%)
Details
codecov/project 7.23% (-0.01%) compared to f3b41ae
Details
CodeFactor No issues found.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.