Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sorted profiles dropdown as in #404 #472

Merged
merged 1 commit into from Sep 4, 2019

Conversation

@Noettore
Copy link
Contributor

Noettore commented Sep 1, 2019

Now the profileBox is alphabetically sorted as requested in #404

Signed-off-by: Ettore Dreucci <ettore.dreucci@gmail.com>
@coveralls

This comment has been minimized.

Copy link

coveralls commented Sep 1, 2019

Coverage Status

Coverage increased (+0.006%) to 7.007% when pulling 24ecf0c on Noettore:feature/sortProfiles into 1087ad7 on IJHack:master.

@codecov

This comment has been minimized.

Copy link

codecov bot commented Sep 1, 2019

Codecov Report

Merging #472 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #472      +/-   ##
========================================
- Coverage    7.41%   7.4%   -0.01%     
========================================
  Files          44     44              
  Lines        2766   2767       +1     
========================================
  Hits          205    205              
- Misses       2561   2562       +1
Impacted Files Coverage Δ
src/mainwindow.cpp 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1087ad7...24ecf0c. Read the comment docs.

@annejan annejan merged commit 30ab999 into IJHack:master Sep 4, 2019
3 of 5 checks passed
3 of 5 checks passed
codecov/patch 0% of diff hit (target 7.41%)
Details
codecov/project 7.4% (-0.01%) compared to 1087ad7
Details
CodeFactor No issues found.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@annejan

This comment has been minimized.

Copy link
Member

annejan commented Sep 4, 2019

Thank you, this is very helpful :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.