Clazy cleanup and other minor fixes #641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
svuorela
commented
Aug 21, 2023
svuorela
commented
- Code is now clazy clean with CLAZY_CHECKS="no-connect-by-name,no-overloaded-signal"
- Given the minimum Qt version is 5.10, remove ifdef's for older versions
- Some more range based for and related cleanups.
- Some include cleanups
- Code is now clazy clean with
CLAZY_CHECKS="no-connect-by-name,no-overloaded-signal"
- Given the minimum Qt version is 5.10, remove ifdef's for older
versions
- Some more range based for and related cleanups.
- Some include cleanups
svuorela
force-pushed
the
svuorela/clazy-and-other-minor-fixes
branch
from
fcdbc26
to
bd1f363
Compare
annejan
approved these changes
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.