Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added keywords for vueTransport method #1350

Closed
wants to merge 1 commit into from
Closed

added keywords for vueTransport method #1350

wants to merge 1 commit into from

Conversation

DevPJ9
Copy link

@DevPJ9 DevPJ9 commented Oct 1, 2022

Pull Request (PR) Checklist

Please check if your pull request fulfills the following requirements:

  • The PR is submitted to the develop branch.
  • I understand the Ivy Developer Guidelines.
  • I've read the Contribution Guidelines.
  • The code builds and is tested on an actual Android device.
  • I confirm that I've run the code locally and everything works as expected.
  • I confirm that I've run Ivy Wallet's UI tests (androidTest) and all tests are passing
    successfully.

Important: Don't worry if you experience flaky UI tests. Just re-run the failed ones again and if they pass => it's all good!

Put an x in the boxes that apply.

  • Demo: Checking checkbox using [x]

Pull Request Type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, new lines, etc.)
  • Refactoring (no functional changes, renaming)
  • Small improvement (fix typo, UI fine-tune, change color or something small)
  • Gradle Build related changes
  • Dependencies update (updating libraries)
  • Documentation (clarifying comments, KDoc)
  • Tests (Unit, Integration, UI tests)
  • Other (please describe):

Put an x in the boxes that apply.

Does this PR closes any GitHub Issues?

Check Ivy Wallet Issues.

  • Closes #N/A (type issue number here)

What's changed?

Describe with a few bullets what's new:

  • a
  • b
  • c
  • d

How to run Ivy Wallet's UI tests (androidTest)

Connect Android Emulator

  • Pixel 5 API 29+ AVD emulator (recommended)
  • Pixel 3XL API 29+ AVD emulator (recommended)
  • Large screen physical device (might also work)

Method 1: Android Studio UI

  • Find com (androidTest) package
  • Right click
  • Run 'Tests in 'com''

Note: If you've checked "Compact Middle Packages" the option will appear as com.ivy.wallet (androidTest).

Method 2: Gradle Wrapper

  • chmod +x gradlew (Linux)
  • ./gradlew connectedDebugAndroidTest

Method 3: Fastlane

  • Install Ruby 2.7
  • bundle install
  • bundle exec fastlane ui_tests

@DevPJ9 DevPJ9 closed this by deleting the head repository Oct 1, 2022
@ILIYANGERMANOV
Copy link
Collaborator

Hi @DevPJ9 can you re-open your PR to develop and commit only the keywords file? Your keywords look good to me!

@DevPJ9
Copy link
Author

DevPJ9 commented Oct 2, 2022

Sure @ILIYANGERMANOV. I am not sure how to remove the .idea file from my commit and I raised this PR for main branch.
Should I make another commit and raise another PR?

@DevPJ9 DevPJ9 reopened this Oct 2, 2022
@DevPJ9 DevPJ9 closed this Oct 2, 2022
@DevPJ9 DevPJ9 reopened this Oct 2, 2022
@ILIYANGERMANOV
Copy link
Collaborator

Hi @DevPJ9 no no, you need the same PR. Just revert the changed file from your branch - https://stackoverflow.com/questions/39459467/remove-a-modified-file-from-pull-request

@DevPJ9
Copy link
Author

DevPJ9 commented Oct 2, 2022

Hey @ILIYANGERMANOV. I have reverted the changes and added new keywords for "vueType" method. Committed those changes in my feature branch as well. However, those changes are not visible here in my PR.

@ILIYANGERMANOV
Copy link
Collaborator

Try this:

  1. copy your kewords changes in another file outside the repo
  2. delete your fork
  3. fork the repo again
  4. git add JUST the keywords file
  5. raise PR

@DevPJ9
Copy link
Author

DevPJ9 commented Oct 2, 2022

Ok. I have raised a new PR with code #1355.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants