Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/1343 #1355

Merged
merged 3 commits into from
Oct 2, 2022
Merged

Feature/1343 #1355

merged 3 commits into from
Oct 2, 2022

Conversation

DevPJ9
Copy link

@DevPJ9 DevPJ9 commented Oct 2, 2022

Pull Request (PR) Checklist

Please check if your pull request fulfills the following requirements:

  • The PR is submitted to the develop branch.
  • I understand the Ivy Developer Guidelines.
  • I've read the Contribution Guidelines.
  • [] The code builds and is tested on an actual Android device.
  • I confirm that I've run the code locally and everything works as expected.
  • I confirm that I've run Ivy Wallet's UI tests (androidTest) and all tests are passing
    successfully.

Important: Don't worry if you experience flaky UI tests. Just re-run the failed ones again and if they pass => it's all good!

Put an x in the boxes that apply.

  • Demo: Checking checkbox using [x]

Pull Request Type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, new lines, etc.)
  • Refactoring (no functional changes, renaming)
  • Small improvement (fix typo, UI fine-tune, change color or something small)
  • Gradle Build related changes
  • Dependencies update (updating libraries)
  • Documentation (clarifying comments, KDoc)
  • Tests (Unit, Integration, UI tests)
  • Other (please describe):

Put an x in the boxes that apply.

Does this PR closes any GitHub Issues?

Check Ivy Wallet Issues.

  • Closes #N/A (type issue number here)

What's changed?

Describe with a few bullets what's new:

  • Added Keywords in "vueTransport" method.
  • Added Keywords in "vueType" method.

How to run Ivy Wallet's UI tests (androidTest)

Connect Android Emulator

  • Pixel 5 API 29+ AVD emulator (recommended)
  • Pixel 3XL API 29+ AVD emulator (recommended)
  • Large screen physical device (might also work)

Method 1: Android Studio UI

  • Find com (androidTest) package
  • Right click
  • Run 'Tests in 'com''

Note: If you've checked "Compact Middle Packages" the option will appear as com.ivy.wallet (androidTest).

Method 2: Gradle Wrapper

  • chmod +x gradlew (Linux)
  • ./gradlew connectedDebugAndroidTest

Method 3: Fastlane

  • Install Ruby 2.7
  • bundle install
  • bundle exec fastlane ui_tests

ILIYANGERMANOV and others added 2 commits October 1, 2022 01:35
1. Added Keywords in "vueTransport" method.
2. Added Keywords in "vueType" method.
@DevPJ9 DevPJ9 mentioned this pull request Oct 2, 2022
17 tasks
@DevPJ9
Copy link
Author

DevPJ9 commented Oct 2, 2022

Hey @ILIYANGERMANOV. The PR failed all test cases. How can I resolve these errors?

@ILIYANGERMANOV
Copy link
Collaborator

e: /home/runner/work/ivy-wallet/ivy-wallet/core/ui/src/main/java/com/ivy/core/ui/icon/picker/IconPickerIcons.kt: (967, 63): Expecting ','

@DevPJ9 there's a syntax error

Fixed Syntax Error
@DevPJ9
Copy link
Author

DevPJ9 commented Oct 2, 2022

e: /home/runner/work/ivy-wallet/ivy-wallet/core/ui/src/main/java/com/ivy/core/ui/icon/picker/IconPickerIcons.kt: (967, 63): Expecting ','

@DevPJ9 there's a syntax error

There was no line (967) end line was (847).
I have checked the keywords for syntax errors and resolved them.
I have cross-checked my changes again to see if there is any remaining syntax errors or not.

@ILIYANGERMANOV ILIYANGERMANOV merged commit 28521ff into Ivy-Apps:develop Oct 2, 2022
@ILIYANGERMANOV
Copy link
Collaborator

Congrats! Your PR is merged successfuly 👍

@DevPJ9
Copy link
Author

DevPJ9 commented Oct 3, 2022

Congrats! Your PR is merged successfuly 👍

Thank you @ILIYANGERMANOV. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants