Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add russian translation #903

Merged
merged 3 commits into from May 15, 2022
Merged

Conversation

llama-0
Copy link
Contributor

@llama-0 llama-0 commented May 13, 2022

Pull Request (PR) Checklist

Please check if your pull request fulfills the following requirements:

  • The PR is submitted to the develop branch.
  • I understand the Ivy Developer Guidelines.
  • I've read the Contribution Guidelines.
  • The code builds and is tested on an actual Android device.
  • I confirm that I've run the code locally and everything works as expected.
  • I confirm that I've run Ivy Wallet's UI tests (androidTest) and all tests are passing
    successfully.

Pull Request Type

Please check the type of change your PR introduces:

  • Other: translation

Does this PR closes any GitHub Issues?

What's changed?

  • added values-ru/strings.xml file

Additional information

In some places in the app translation is not truly correct due to this issue I raised earlier. I'll take this issue next or leave it for someone else who's also interested.

@ILIYANGERMANOV
Copy link
Collaborator

Hi @llama-0, thank you for your PR! I guess there are missing translation or other errors because "lint" check is failing. Can you have a look?

@StarHamster
Copy link
Contributor

I'll work on it and fix it

@ILIYANGERMANOV
Copy link
Collaborator

@StarHamster the error:

23:21:21]: ▸ /home/runner/work/ivy-wallet/ivy-wallet/app/src/main/res/values-ru/strings.xml:65: Error: Inconsistent formatting types for argument #1 in format string transactions_imported ('%1$s'): Found both 's' here and 'd' in values/strings.xml [StringFormatMatches]
[23:21:21]: ▸ %1$s транзакций
[23:21:21]: ▸ ~~~~
[23:21:21]: ▸ /home/runner/work/ivy-wallet/ivy-wallet/app/src/main/res/values/strings.xml:65: Conflicting argument type (`d') here

@StarHamster
Copy link
Contributor

Yeah, I saw, thx @ILIYANGERMANOV . There're many other mistakes. I'll add fix commit tommorow 💤

@ILIYANGERMANOV ILIYANGERMANOV merged commit eb02558 into Ivy-Apps:develop May 15, 2022
@llama-0
Copy link
Contributor Author

llama-0 commented May 15, 2022

Hi! I'm sorry I've missed so many things 😱Thank you for all the corrections! This is my first ever contribution to opensource, I'm extremely nervous, but I hope I'll do better in the future.

@ILIYANGERMANOV
Copy link
Collaborator

No worries, @llama-0! We appreciate your contribution and would be happy to see more in future 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants