Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Plugin Docs for up to date topic information #189

Merged
merged 8 commits into from
Mar 12, 2021

Conversation

therishidesai
Copy link
Member

No description provided.

@therishidesai therishidesai added documentation Improvements or additions to documentation WIP Work in progress labels Nov 10, 2020
@therishidesai therishidesai linked an issue Nov 10, 2020 that may be closed by this pull request
e3m3
e3m3 previously approved these changes Jan 13, 2021
@mhuzai mhuzai dismissed e3m3’s stale review January 15, 2021 05:27

Some topics are missing (e.g., the newly added ground truth one) and audio and hologram still need to be done. As an aside, I've always wanted to see what happens when you dismiss a review. :P

@charmoniumQ charmoniumQ marked this pull request as draft January 21, 2021 01:49
@charmoniumQ charmoniumQ changed the title [WIP] Update Plugin Docs for up to date topic information Update Plugin Docs for up to date topic information Jan 21, 2021
@charmoniumQ
Copy link
Member

We should separate subscribed into subscribed/scheduled and asynchronously read.

@charmoniumQ charmoniumQ self-assigned this Mar 3, 2021
@charmoniumQ charmoniumQ removed the WIP Work in progress label Mar 3, 2021
@charmoniumQ charmoniumQ marked this pull request as ready for review March 3, 2021 22:56
@charmoniumQ charmoniumQ requested review from e3m3 and removed request for charmoniumQ March 3, 2021 22:56
@e3m3 e3m3 force-pushed the issue-186-update-plugin-docs branch from d05f416 to 52410f4 Compare March 6, 2021 00:06
charmoniumQ
charmoniumQ previously approved these changes Mar 8, 2021
e3m3
e3m3 previously approved these changes Mar 9, 2021
Copy link
Member

@mhuzai mhuzai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not merge without addressing these comments first.

docs/illixr_plugins.md Show resolved Hide resolved
docs/illixr_plugins.md Outdated Show resolved Hide resolved
docs/illixr_plugins.md Show resolved Hide resolved
docs/illixr_plugins.md Outdated Show resolved Hide resolved
docs/illixr_plugins.md Outdated Show resolved Hide resolved
docs/illixr_plugins.md Outdated Show resolved Hide resolved
docs/illixr_plugins.md Outdated Show resolved Hide resolved
docs/illixr_plugins.md Outdated Show resolved Hide resolved
docs/illixr_plugins.md Outdated Show resolved Hide resolved
@e3m3 e3m3 self-assigned this Mar 10, 2021
@e3m3 e3m3 dismissed stale reviews from charmoniumQ and themself via afe9cfc March 10, 2021 18:45
@e3m3 e3m3 force-pushed the issue-186-update-plugin-docs branch from f0c5663 to 30aefd2 Compare March 11, 2021 17:10
@e3m3 e3m3 requested review from charmoniumQ and mhuzai March 11, 2021 17:14
@mhuzai mhuzai merged commit 0e6901b into master Mar 12, 2021
@mhuzai mhuzai deleted the issue-186-update-plugin-docs branch May 25, 2021 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the plugins page to have a list of topics
4 participants