Fix timing infrastructure #221
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e3m3
force-pushed
the
issue-32-fix-mem-leak
branch
from
4a6307d
to
cec6035
Compare
e3m3
force-pushed
the
issue-32-fix-mem-leak
branch
from
cec6035
to
41ed42b
Compare
e3m3
force-pushed
the
issue-32-fix-mem-leak
branch
2 times, most recently
from
1b0b1a4
to
4e93aed
Compare
e3m3
force-pushed
the
issue-32-fix-mem-leak
branch
from
4e93aed
to
70aa41b
Compare
e3m3
force-pushed
the
issue-32-fix-mem-leak
branch
3 times, most recently
from
5ca32f6
to
9e36825
Compare
Open
mvanmoer
added a commit
that referenced
this pull request
Aug 18, 2023
The top of file contains a large comment describing the timer infrastructure. It references a test.sh which can be used to determine the timing infrastructure overhead. This file exists only on the project-scheduling branch. (Reminder - this PR was created from bits and pieces of the project-scheduling and issue-209-cpu-timer branches, as well as PR #221.) It is a BASH script which uses bazel. However, I can't locate the actual tests. E.g. the first bazel command is bazel run //include:cpu_timer_minimal_test \ # etc ripgrep returns nothing for "cpu_timer_minimal_test" and find returns there are no files with that file name.
|
Superceded by PR 383 |
astro-friedel
pushed a commit
that referenced
this pull request
Mar 27, 2024
The top of file contains a large comment describing the timer infrastructure. It references a test.sh which can be used to determine the timing infrastructure overhead. This file exists only on the project-scheduling branch. (Reminder - this PR was created from bits and pieces of the project-scheduling and issue-209-cpu-timer branches, as well as PR #221.) It is a BASH script which uses bazel. However, I can't locate the actual tests. E.g. the first bazel command is bazel run //include:cpu_timer_minimal_test \ # etc ripgrep returns nothing for "cpu_timer_minimal_test" and find returns there are no files with that file name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #208. Dependent on pending PRs for #220 and open_vins #2.
I have broken off the CPU timer into a separate repo here so that it can be reused between projects.
It will be the responsibility of a future PR to log that data to disk (issue #211).
This PR removes the old SQLite logging infrastructure. Logs that use or add-to the stack-frame's context should be added into the "extra info" of the CPU timer. Logs that do not should be converted to Switchboard topics and logged into a bag.
This PR is for the interface of the CPU timer. The reviewer should verify:
Got 75493 finished framesa few times (once for each thread) at the finish.