Canonicalize scripts #264
Merged
Canonicalize scripts #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e3m3
added
bug
|
Pardon the bash scripts. These prototypes should be moved to Python (or similar) once the build/package interfaces are more mature, and should reflect the results of #104's discussions. |
|
Closes #256. |
e3m3
force-pushed
the
issue-263-canonicalize-scripts
branch
from
8766350
to
743ba9c
Compare
charmoniumQ
previously approved these changes
Apr 6, 2021
charmoniumQ
reviewed
Apr 6, 2021
charmoniumQ
reviewed
Apr 6, 2021
install_deps.sh
Outdated
| else | ||
| dep_log_path_conda="${dep_log_path}" | ||
| src_dir_conda="${parent_dir_conda}/${dep_name_conda}" | ||
| print_warning "Installation log for conda not found at '${dep_log_path_conda}'." |
There was a problem hiding this comment.
Does conda not found imply we should quit?
There was a problem hiding this comment.
Yeah I think it would be safe to abort here. The script is written to try for conda anyway below as a stop-gap (detect_dependency is only looking for a log entry in .deps/, but conda can still have been installed via a previous version of the script, or via the system).
charmoniumQ
previously approved these changes
Apr 6, 2021
charmoniumQ
previously approved these changes
Apr 9, 2021
e3m3
force-pushed
the
issue-263-canonicalize-scripts
branch
4 times, most recently
from
fb17488
to
7c2b7be
Compare
charmoniumQ
previously approved these changes
Apr 22, 2021
- Moved 'deps' -> '.cache/deps' - Moved 'runner/environment.yml' -> '.cache/runner/environment.yml' - Removed CUDA from OpenCV build/install - Fixed type in 'docs/illixr_plugins.md'
- New clang dependency (10.0.1) - New boost depdendecy (1.65.1) - Removed 'clang-10' from 'scripts/install_apt_deps.sh' - Removed 'libboost-all-dev' from 'scripts/install_apt_deps.sh' - Fixed deps configuraton detection - Fixed in conda environment creating in 'Dockerfile'
- Made 'scripts/install_clang.sh' executable - Made 'scripts/install_boost.sh' executable - Added clang and boost to 'Dockerfile' - Fixed environment creation in 'install_deps.sh'
- Disabled boost installation (from source) - Disabled clang installation (from source) - New 'join_strings' utility in 'scripts/system_utils.sh'
e3m3
force-pushed
the
issue-263-canonicalize-scripts
branch
from
f77ca73
to
2779389
Compare
mhuzai
approved these changes
May 10, 2021
charmoniumQ
approved these changes
May 10, 2021
charmoniumQ
approved these changes
May 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #263. Depends on #261.
Changes: