Fix docs

[charmoniumQ]

No description provided.

[wsherman64]

The version of the most basic plugin in the online IlliXR documentation has a bug in that the start() method of a threadloop style plugin should not be overridden.

Here is a replacement that I'm now using, which includes a couple additional comments, plus some output to demonstrate that the plugin works:

// A minimal/no-op IlliXR plugin

#include "common/phonebook.hpp"
#include "common/plugin.hpp"
#include "common/threadloop.hpp"

using namespace ILLIXR;

/// Inherit from plugin if you don't need the threadloop
/// Inherit from threadloop to provide a new thread to perform the task
class basic_plugin : public threadloop {
public:
basic_plugin(std::string name_, phonebook* pb_)
: threadloop{name_, pb_}
{
printf("Starting Plugin basic_plugin\n");
RAC_ERRNO_MSG("basic_plugin in constructor");
}
virtual ~basic_plugin() override {
printf("Ending Plugin basic_plugin\n");
RAC_ERRNO_MSG("basic_plugin in destructor");
}

// Do not override the start() method (for `threadloop` style plugins)       
                                                                             
// _p_one_iteration() is called from with the threadloop start() method      
void _p_one_iteration() override {                                           
    printf("Iteration of basic_plugin\n");                                   
    RAC_ERRNO_MSG("basic_plugin at end of _p_one_iteration");                
}                                                                            

};

// This line makes the plugin importable by Spindle
PLUGIN_MAIN(basic_plugin); ```

[charmoniumQ]

@wsherman64, I removed the RAC_*, since we are moving away from that. But otherwise, I've incorporated those changes.

[mhuzai]

I don't understand the distinction between log and console here given that both prints are to cout.

[charmoniumQ]

How about now?