Rebase issue 50 separate imu cam revert repeated commits #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s' of https://github.com/ILLIXR/ILLIXR into rebase-issue-50-separate-imu-cam-revert-repeated-commits
jianxiapyh
reviewed
Dec 2, 2022
jianxiapyh
reviewed
Dec 15, 2022
jianxiapyh
reviewed
Dec 19, 2022
Boyuan-Tian
previously approved these changes
Dec 19, 2022
jianxiapyh
previously approved these changes
Dec 19, 2022
EliFeinberg
dismissed stale reviews from jianxiapyh and Boyuan-Tian
via
2b41e8e
Boyuan-Tian
previously approved these changes
Jan 10, 2023
jianxiapyh
previously approved these changes
Jan 10, 2023
qinjunj
force-pushed
the
rebase-issue-50-separate-imu-cam-revert-repeated-commits
branch
from
f34cbe1
to
6f3f0ed
Compare
qinjunj
force-pushed
the
rebase-issue-50-separate-imu-cam-revert-repeated-commits
branch
from
a584139
to
a8e09e8
Compare
qinjunj
force-pushed
the
rebase-issue-50-separate-imu-cam-revert-repeated-commits
branch
from
31d2bb7
to
6d97977
Compare
Boyuan-Tian
approved these changes
Jan 19, 2023
jianxiapyh
approved these changes
Jan 19, 2023
mvanmoer
pushed a commit
that referenced
this pull request
Jan 31, 2023
* split imu_cam and no optional needed * add buffered reader related to switchboard * add internal_stop to threadloop * update yaml files * split imu and cam for debugview * split imu and cam for zed realsense depthai * created offline_imu and offline_cam * split imu and cam for offload_vio * split imu and cam for record_imu_cam * split imu and cam for integrators * split imu and cam for ground_truth_slam * responses to reviews * Fixed leftover issue while resolving conflicts * [pre-commit.ci] Run clang-format * [pre-commit.ci] Run clang-format * fix rk4 and change imu data type to doubles * [pre-commit.ci] Run clang-format * start realsense only after the clock is started * [pre-commit.ci] Run clang-format * Fixed Eigen Matrices type conversion * clean up and address reviewer's comments * [pre-commit.ci] Run clang-format * address reviewer comments * address reviewer comments, fix offload, change tags, move csv_iterator to common * [pre-commit.ci] Run clang-format * Cleaned up branch by removing include opencv that are unused in data_loading.hpp * address reviewers' comments * test changes in Kimera * use fixed Kimera * change Kimera tag * [pre-commit.ci] Run clang-format Co-authored-by: Henry Che <daihung.che@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Eli Feinberg <elifeinberg@gmail.com>
EliFeinberg
pushed a commit
that referenced
this pull request
Feb 9, 2023
This reverts commit b60a2a9.
mvanmoer
pushed a commit
that referenced
this pull request
Mar 2, 2023
* split imu_cam and no optional needed * add buffered reader related to switchboard * add internal_stop to threadloop * update yaml files * split imu and cam for debugview * split imu and cam for zed realsense depthai * created offline_imu and offline_cam * split imu and cam for offload_vio * split imu and cam for record_imu_cam * split imu and cam for integrators * split imu and cam for ground_truth_slam * responses to reviews * Fixed leftover issue while resolving conflicts * [pre-commit.ci] Run clang-format * [pre-commit.ci] Run clang-format * fix rk4 and change imu data type to doubles * [pre-commit.ci] Run clang-format * start realsense only after the clock is started * [pre-commit.ci] Run clang-format * Fixed Eigen Matrices type conversion * clean up and address reviewer's comments * [pre-commit.ci] Run clang-format * address reviewer comments * address reviewer comments, fix offload, change tags, move csv_iterator to common * [pre-commit.ci] Run clang-format * Cleaned up branch by removing include opencv that are unused in data_loading.hpp * address reviewers' comments * test changes in Kimera * use fixed Kimera * change Kimera tag * [pre-commit.ci] Run clang-format Co-authored-by: Henry Che <daihung.che@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Eli Feinberg <elifeinberg@gmail.com>
jianxiapyh
pushed a commit
that referenced
this pull request
May 14, 2023
* split imu_cam and no optional needed * add buffered reader related to switchboard * add internal_stop to threadloop * update yaml files * split imu and cam for debugview * split imu and cam for zed realsense depthai * created offline_imu and offline_cam * split imu and cam for offload_vio * split imu and cam for record_imu_cam * split imu and cam for integrators * split imu and cam for ground_truth_slam * responses to reviews * Fixed leftover issue while resolving conflicts * [pre-commit.ci] Run clang-format * [pre-commit.ci] Run clang-format * fix rk4 and change imu data type to doubles * [pre-commit.ci] Run clang-format * start realsense only after the clock is started * [pre-commit.ci] Run clang-format * Fixed Eigen Matrices type conversion * clean up and address reviewer's comments * [pre-commit.ci] Run clang-format * address reviewer comments * address reviewer comments, fix offload, change tags, move csv_iterator to common * [pre-commit.ci] Run clang-format * Cleaned up branch by removing include opencv that are unused in data_loading.hpp * address reviewers' comments * test changes in Kimera * use fixed Kimera * change Kimera tag * [pre-commit.ci] Run clang-format Co-authored-by: Henry Che <daihung.che@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Eli Feinberg <elifeinberg@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix rebase in #339 and revert repeated commits.
Adapts offload-vio to separated imu and cam; update to the TCP implementation.
Close #339.