Offload rebase #409
Merged
Offload rebase #409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… GT biases, debugging pose prediction
…ness of the frame and whether a frame is dropped, change server_tx client_rx communication using tcp socket
Closed
jianxiapyh
previously approved these changes
Sep 15, 2023
There was a problem hiding this comment.
The code looks good to me for now. However, I can only run 'offload-device' and not 'offload-monado', since your current code assumes that CMake 3.24 is being used (otherwise, 'timewarp_vk' will not compile). However, Steven mentioned that Doug might have fixed this in a later branch, so I am inclined to approve it for now.
with 3.24, both offload-device and offload-monado worked
with 3.20, only offload-device worked
…into offload_last_rebase
jianxiapyh
approved these changes
Sep 15, 2023
Boyuan-Tian
approved these changes
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR rebases on top of the new master and closes #405. All comments at #405 are resolved.