Skip to content

Commit

Permalink
Fix lexing illegal exponential, Fix for issue jerryscript-project#339
Browse files Browse the repository at this point in the history
JerryScript-DCO-1.0-Signed-off-by: Ilyong Cho ily.cho@samsung.com
  • Loading branch information
ILyoan committed Oct 19, 2015
1 parent 08c618e commit 28a0623
Show file tree
Hide file tree
Showing 2 changed files with 29 additions and 1 deletion.
6 changes: 5 additions & 1 deletion jerry-core/parser/js/lexer.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -949,7 +949,11 @@ lexer_parse_number (void)
if (is_fp || is_exp)
{
ecma_number_t res = ecma_utf8_string_to_number (TOK_START (), (jerry_api_size_t) tok_length);
JERRY_ASSERT (!ecma_number_is_nan (res));

if (ecma_number_is_nan (res))
{
PARSE_ERROR (JSP_EARLY_ERROR_SYNTAX, "Illegal numeric literal", token_start_pos);
}

known_token = convert_seen_num_to_token (res);
is_token_parse_in_progress = NULL;
Expand Down
24 changes: 24 additions & 0 deletions tests/jerry/regression-test-issue-339.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
// Copyright 2015 Samsung Electronics Co., Ltd.
// Copyright 2015 University of Szeged.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

try
{
eval ('var y = 4e;');
assert (false);
}
catch (e)
{
assert (e instanceof SyntaxError);
}

0 comments on commit 28a0623

Please sign in to comment.