fix(creditNote): reverse all rows in a reversal

This commit changes the `ReverseTransaction()` method to using UNION
ALL instead of a simple UNION to avoid only reversing unique rows.  This
has resulted in multiple unbalanced credit notes in production.

client/src/js/services/VoucherService.js

@@ -77,7 +77,8 @@ function VoucherService(Api, $http, util, TransactionTypeStore) {
    * This method facilitate annulling a transaction,
    * bhima should automatically be able to reverse
    * any transaction in the posting_journal by creating a
-   * new transaction that is an exact duplicate of the original transaction with sign minous.
+   * new transaction that is an exact duplicate of the original transaction with the
+   * debits and credits switched.
    */
   function reverse(creditNote) {
     return $http.post(baseUrl.concat(creditNote.uuid, '/reverse'), creditNote)

server/controllers/finance/journal/index.js

@@ -197,7 +197,7 @@ function find(options) {
 * journalEntryList
 * Allows you to select which transactions to print
 */
-function journalEntryList(options) { 
+function journalEntryList(options) {
   let uuids =  options.uuids.map(function(uuid) {
     return db.bid(uuid);
   });
@@ -293,7 +293,7 @@ function getTransaction (req, res, next) {
  *
  * @description
  * This is a generic wrapper for reversing any transaction in the posting
- * journal or general ledger. 
+ * journal or general ledger.
  *
  * POST /journal/:uuid/reverse
  */
@@ -303,20 +303,20 @@ function reverse(req, res, next) {
   const recordUuid  = db.bid(req.params.uuid);
   const params = [ recordUuid, req.session.user.id, req.body.description, db.bid(voucherUuid) ];
 
-  /** 
-   * Check already cancelled 
+  /**
+   * Check already cancelled
    * Transaction type for cancelled operation is 10
    */
   const CANCELLED_ID = 10;
-  const query = 
-    `SELECT uuid FROM voucher 
+  const query =
+    `SELECT uuid FROM voucher
      WHERE voucher.type_id = ${CANCELLED_ID} AND voucher.reference_uuid = ?`;
 
-  // create and execute a transaction if necessary 
+  // create and execute a transaction if necessary
   db.exec(query, [recordUuid])
     .then(rows => {
       if (rows.length > 0) {
-        // transaction already cancelled 
+        // transaction already cancelled
         throw new BadRequest('The transaction has been already cancelled', 'POSTING_JOURNAL.ERRORS.MULTIPLE_CANCELLING');
       }
       return db.exec('CALL ReverseTransaction(?, ?, ?, ?);', params);

server/models/procedures.sql

@@ -548,7 +548,7 @@ BEGIN
 
   DECLARE cashPaymentOriginId SMALLINT(5);
 
-  -- set origin to the CASH_PAYMENT transaction type 
+  -- set origin to the CASH_PAYMENT transaction type
   SET cashPaymentOriginId = 2;
 
   -- copy cash payment values into working variables
@@ -1128,7 +1128,7 @@ BEGIN
     SELECT voucher_uuid, NOW(), zz.project_id, enterprise.currency_id, 0, CONCAT_WS(' ', '[REVERSAL]', description, ' -- ', zz.description), user_id, 10, uuid
     FROM (
       SELECT pj.project_id, pj.description FROM posting_journal AS pj WHERE pj.record_uuid = uuid
-      UNION
+      UNION ALL
       SELECT gl.project_id, gl.description FROM general_ledger AS gl WHERE gl.record_uuid = uuid
     ) AS zz
       JOIN project ON zz.project_id = project.id
@@ -1141,7 +1141,7 @@ BEGIN
     FROM (
       SELECT pj.account_id, pj.credit_equiv, pj.debit_equiv, pj.reference_uuid, pj.entity_uuid
       FROM posting_journal AS pj WHERE pj.record_uuid = uuid
-      UNION
+      UNION ALL
       SELECT gl.account_id, gl.credit_equiv, gl.debit_equiv, gl.reference_uuid, gl.entity_uuid
       FROM general_ledger AS gl WHERE gl.record_uuid = uuid
     ) AS zz;