Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Voucher registry filter by default by the current day #1464

Merged
merged 1 commit into from
Apr 4, 2017

Conversation

mbayopanda
Copy link
Contributor

@mbayopanda mbayopanda commented Apr 4, 2017

This PR fixes the issue #1457.

Closes #1457.

Copy link
Contributor

@jniles jniles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@@ -149,20 +158,25 @@ function VoucherController(Vouchers, Notify, Filtering, uiGridGroupingConstants,
Receipts.voucher(uuid);
}

function isEmpty(object) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice abstraction 👍

var transaction = get(voucher.type_id);
voucher._isIncome = (transaction.type === INCOME);
voucher._isExpense = (transaction.type === EXPENSE);
voucher._isOther = (transaction.type === OTHER);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jniles jniles merged commit 9b88b1e into IMA-WorldHealth:master Apr 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(performance) Limit Voucher Registry to "today" by default
2 participants