-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Voucher registry filter by default by the current day #1464
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,7 +4,8 @@ angular.module('bhima.controllers') | |
// dependencies injection | ||
VoucherController.$inject = [ | ||
'VoucherService', 'NotifyService', 'GridFilteringService', 'uiGridGroupingConstants', 'uiGridConstants', | ||
'bhConstants', 'ReceiptModal', 'GridSortingService', '$state', 'appcache' | ||
'bhConstants', 'ReceiptModal', 'GridSortingService', '$state', 'appcache', | ||
'FilterService', | ||
]; | ||
|
||
/** | ||
|
@@ -13,16 +14,21 @@ VoucherController.$inject = [ | |
* @description | ||
* This controller is responsible for display all vouchers in the voucher table. | ||
*/ | ||
function VoucherController(Vouchers, Notify, Filtering, uiGridGroupingConstants, uiGridConstants, bhConstants, Receipts, Sorting, $state, AppCache) { | ||
function VoucherController(Vouchers, Notify, Filtering, uiGridGroupingConstants, | ||
uiGridConstants, bhConstants, Receipts, Sorting, $state, AppCache, | ||
Filters) { | ||
var vm = this; | ||
var filter = new Filters(); | ||
var filtering; | ||
var FILTER_BAR_HEIGHT; | ||
var cache = new AppCache('VoucherRegistry'); | ||
|
||
var INCOME = bhConstants.transactionType.INCOME; | ||
var EXPENSE = bhConstants.transactionType.EXPENSE; | ||
var OTHER = bhConstants.transactionType.OTHER; | ||
|
||
/* global variables */ | ||
vm.filter = filter; | ||
vm.filterEnabled = false; | ||
vm.transactionTypes = {}; | ||
vm.gridApi = {}; | ||
|
@@ -45,8 +51,6 @@ function VoucherController(Vouchers, Notify, Filtering, uiGridGroupingConstants, | |
flatEntityAccess : true, | ||
fastWatch : true, | ||
enableFiltering : vm.filterEnabled, | ||
fastWatch : true, | ||
flatEntityAccess : true, | ||
rowTemplate : '/partials/templates/grid/voucher.row.html', | ||
}; | ||
|
||
|
@@ -139,6 +143,11 @@ function VoucherController(Vouchers, Notify, Filtering, uiGridGroupingConstants, | |
Vouchers.openSearchModal(vm.filters) | ||
.then(function (parameters) { | ||
if (!parameters) { return; } | ||
|
||
if (parameters.defaultPeriod) { | ||
delete parameters.defaultPeriod; | ||
} | ||
|
||
cacheFilters(parameters); | ||
return load(vm.filters); | ||
}); | ||
|
@@ -149,20 +158,25 @@ function VoucherController(Vouchers, Notify, Filtering, uiGridGroupingConstants, | |
Receipts.voucher(uuid); | ||
} | ||
|
||
function isEmpty(object) { | ||
return Object.keys(object).length === 0; | ||
} | ||
|
||
function load(parameters) { | ||
// flush error and loading states | ||
vm.hasError = false; | ||
toggleLoadingIndicator(); | ||
|
||
Vouchers.read(null, parameters) | ||
.then(function (vouchers) { | ||
Vouchers.read(null, parameters).then(function (vouchers) { | ||
vm.gridOptions.data = vouchers; | ||
|
||
// loop through the vouchers and precompute the voucher type tags | ||
vouchers.forEach(function (voucher) { | ||
voucher._isIncome = (voucher.type_id === INCOME); | ||
voucher._isExpense = (voucher.type_id === EXPENSE); | ||
voucher._type = get(voucher.type_id).text; | ||
var transaction = get(voucher.type_id); | ||
voucher._isIncome = (transaction.type === INCOME); | ||
voucher._isExpense = (transaction.type === EXPENSE); | ||
voucher._isOther = (transaction.type === OTHER); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍 |
||
voucher._type = transaction.text; | ||
}); | ||
|
||
vm.gridApi.core.notifyDataChange(uiGridConstants.dataChange.ALL); | ||
|
@@ -180,6 +194,7 @@ function VoucherController(Vouchers, Notify, Filtering, uiGridGroupingConstants, | |
|
||
// save the parameters to use later. Formats the parameters in filtersFmt for the filter toolbar. | ||
function cacheFilters(filters) { | ||
filters = filter.applyDefaults(filters); | ||
vm.filters = cache.filters = filters; | ||
vm.filtersFmt = Vouchers.formatFilterParameters(filters); | ||
|
||
|
@@ -197,7 +212,7 @@ function VoucherController(Vouchers, Notify, Filtering, uiGridGroupingConstants, | |
// clears the filters by forcing a cache of an empty array | ||
function clearFilters() { | ||
cacheFilters({}); | ||
load(); | ||
load(vm.filters); | ||
} | ||
|
||
/** | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice abstraction 👍