-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(Complete insuffisance test E2E) #1740
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lomamech, very nicely implemented tests. This was a good catch.
We already have a component for clearing search form inputs - it's bhClear
and you should use it here.
Most places use a ui-select
for debtor groups (e.g. Patient Registration), so it would probably be best to use one here.
After that, LGTM!
</span> | ||
|
||
<!-- @todo make data driven selects components to handle loading and error states --> | ||
<select |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In most places, I think we use a ui-select
for debtor groups. We should probably use the same here.
|
||
<!-- @todo make this a component - it is used everywhere. Calls back method | ||
`clear` and resets the id passed to the component --> | ||
<span style="display:inline-block;" class="pull-right"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should use bhClear
. See #1702.
@@ -70,6 +71,12 @@ function CashPaymentsRegistryTests() { | |||
GU.expectRowCount('payment-registry', PAYMENT_INSIDE_REGISTRY); | |||
}); | |||
|
|||
it('finds all payments for creditor group Second Test Debtor Group', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
|
||
<!-- @todo make this a component - it is used everywhere. Calls back method | ||
`clear` and resets the id passed to the component --> | ||
<span style="display:inline-block;" class="pull-right"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same for here! You can also remove that @todo
... we implemented it in bhClear
.
- Complete test E2E for the research with the inventorie group uuid in Cash registry, Patient Registry and Invoice Registry - Update some function the test E2E - Update API for cash and patient invoice
- Use ui-select instead select - Use componant bhClear and fix issue 1702 - Update test E2E closes IMA-WorldHealth#1702
6abd299
to
5994a7a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
<i class="fa fa-eraser"></i> <span translate>FORM.BUTTONS.CLEAR</span> | ||
</a> | ||
</span> | ||
<bh-clear on-clear="ModalCtrl.clear('group_uuid')"></bh-clear> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Much cleaner!
test(Complete insuffisance test E2E
in Cash registry, Patient Registry and Invoice Registry
closes #1733