test(Complete insuffisance test E2E) #1740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jniles
suggested changes
Jun 2, 2017
There was a problem hiding this comment.
@lomamech, very nicely implemented tests. This was a good catch.
We already have a component for clearing search form inputs - it's bhClear and you should use it here.
Most places use a ui-select for debtor groups (e.g. Patient Registration), so it would probably be best to use one here.
After that, LGTM!
| </span> | ||
|
|
||
| <!-- @todo make data driven selects components to handle loading and error states --> | ||
| <select |
There was a problem hiding this comment.
In most places, I think we use a ui-select for debtor groups. We should probably use the same here.
|
|
||
| <!-- @todo make this a component - it is used everywhere. Calls back method | ||
| `clear` and resets the id passed to the component --> | ||
| <span style="display:inline-block;" class="pull-right"> |
There was a problem hiding this comment.
This should use bhClear. See #1702.
| @@ -70,6 +71,12 @@ function CashPaymentsRegistryTests() { | |||
| GU.expectRowCount('payment-registry', PAYMENT_INSIDE_REGISTRY); | |||
| }); | |||
|
|
|||
| it('finds all payments for creditor group Second Test Debtor Group', () => { | |||
|
|
||
| <!-- @todo make this a component - it is used everywhere. Calls back method | ||
| `clear` and resets the id passed to the component --> | ||
| <span style="display:inline-block;" class="pull-right"> |
There was a problem hiding this comment.
Same for here! You can also remove that @todo ... we implemented it in bhClear.
- Complete test E2E for the research with the inventorie group uuid in Cash registry, Patient Registry and Invoice Registry - Update some function the test E2E - Update API for cash and patient invoice
- Use ui-select instead select - Use componant bhClear and fix issue 1702 - Update test E2E closes IMA-WorldHealth#1702
lomamech
force-pushed
the
insuffisanceTestE2E
branch
from
6abd299
to
5994a7a
Compare
jniles
approved these changes
Jun 2, 2017
| <i class="fa fa-eraser"></i> <span translate>FORM.BUTTONS.CLEAR</span> | ||
| </a> | ||
| </span> | ||
| <bh-clear on-clear="ModalCtrl.clear('group_uuid')"></bh-clear> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test(Complete insuffisance test E2E
in Cash registry, Patient Registry and Invoice Registry
closes #1733