-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(proposal) Journal transaction editing history #2046
Comments
To clarify, This proposal LGTM. Just knowing if a transaction has been messed with can inform us what next questions to ask. |
Note - this is tangentially related to #1559 |
I'll tackle this one. The optional fields don't make much sense to me - this kind of resolution needs to be available on a line-by-line basis, not a transaction basis. The only update I'll make is renaming |
This commit contains the first implementation of the transaction_history proposed in IMA-WorldHealth#2046. It implements the table and triggers to update the transaction_history after the transaction has been edited. Closes IMA-WorldHealth#2046.
2156: Feature: Transaction History r=DedrickEnc a=jniles This PR implements transaction histories as described in #2046. A new table has been added - `transaction_history`. This table contains the `record_uuid` of a transaction, the user id, and a timestamp for when it was edited. The table is updated during the transaction edit database transaction. Using this simplistic implementation, I've also included a small text on the Edit Transaction modal to show when the last edit was and by whom. See below: ![transactionhistorydisplay](https://user-images.githubusercontent.com/896472/30869253-937a4ec6-a2d8-11e7-8073-c54f8ed136dd.png) _Fig 1: Transaction History Display in the Bottom Left of the Modal._
Closed in #2156. |
We currently have no way of differentiating transactions that have been edited and transactions that were directly written by the system.
If an accountant or developer is trying to audit the system to find out where something has gone wrong it would be very useful to know if something has been changed to know where to look for the issue.
I propose we introduce a new table
transaction_history
that we will write in every time an editing session is successfully run on a transaction.The columns would be
Whilst this doesn't give us a history of the full transaction it will be a good first step towards answering questions:
Has a transaction been edited?
Who has edited a specific transaction?
The text was updated successfully, but these errors were encountered: