New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Design: Deleting Cash Payments #2159

Closed

jniles opened this issue Sep 27, 2017 · 1 comment

Assignees

Labels

design

Collaborator

jniles commented Sep 27, 2017 •

edited

Loading

This issue covers the design for deleting Cash Payments using the proposal described in #2044.

Design
Deleting cash payments will be done from the Cash Payment Registry and the Posting Journal (via the transaction edit modal). It is not allowed on posted records. A deleted Cash Payment will remove the lines from the posting_journal, cash, and cash_item. It will also remove the record_uuid from the document_map.

There are some conditional rules on this operation:

If the cash payment is posted, it cannot be deleted. The only way to reverse a posted record is by using a credit note.
If the cash payment has a referencing transaction, it cannot be deleted. This is most likely a voucher that is reversing the cash payment (as a credit note).

The steps to implement this are:

Create a routing function from HTTP DELETE /transactions/:uuid that will determine if the transaction is a cash payment, voucher, or invoice.
Create the safelyDeleteCashPayment(uuid) in the finance/cash.js. module.
Write the SQL logic to determine if the cash payment should be deleted as described in the above rules.
Put in the client-side "delete" button on the transaction modal and on the Cash Payment registry.

The text was updated successfully, but these errors were encountered:

jniles added the design label

jniles changed the title ~~design: deleting Cash Payments~~ Design: Deleting Cash Payments

jniles self-assigned this

jniles mentioned this issue

Design: Deleting Vouchers #2161

Closed

jniles added a commit that referenced this issue


          feat(cash): delete cash payments

5ad0a17

This commit implements the server-side logic and code for deleting cash
payments.  An integration tests shows that the functionality is intact.
This goes halfway to addressing #2159.

jniles added a commit that referenced this issue


          feat(cash): implement client delete record

bd7eea3

This commit implements the client-side for deleting a cash record.  It
simply adds a new value to the dropdown that can be clicked to remove
the record.

TODO - add end-to-end tests.

Closes #2159.

jniles mentioned this issue

feature: delete records #2188

Merged

3 tasks

jniles added a commit that referenced this issue


          feat(cash): delete cash payments

702cba0

This commit implements the server-side logic and code for deleting cash
payments.  An integration tests shows that the functionality is intact.
This goes halfway to addressing #2159.

jniles added a commit that referenced this issue


          feat(cash): implement client delete record

444bdc4

This commit implements the client-side for deleting a cash record.  It
simply adds a new value to the dropdown that can be clicked to remove
the record.

TODO - add end-to-end tests.

Closes #2159.

jniles added a commit that referenced this issue


          feat(cash): delete cash payments

e433c26

This commit implements the server-side logic and code for deleting cash
payments.  An integration tests shows that the functionality is intact.
This goes halfway to addressing #2159.

jniles added a commit that referenced this issue


          feat(cash): implement client delete record

ec0442e

This commit implements the client-side for deleting a cash record.  It
simply adds a new value to the dropdown that can be clicked to remove
the record.

TODO - add end-to-end tests.

Closes #2159.

jniles added a commit that referenced this issue


          feat(cash): delete cash payments

277534f

This commit implements the server-side logic and code for deleting cash
payments.  An integration tests shows that the functionality is intact.
This goes halfway to addressing #2159.

jniles added a commit that referenced this issue


          feat(cash): implement client delete record

8012f65

This commit implements the client-side for deleting a cash record.  It
simply adds a new value to the dropdown that can be clicked to remove
the record.

TODO - add end-to-end tests.

Closes #2159.

jniles added a commit that referenced this issue


          feat(cash): delete cash payments

144d9f7

This commit implements the server-side logic and code for deleting cash
payments.  An integration tests shows that the functionality is intact.
This goes halfway to addressing #2159.

jniles added a commit that referenced this issue


          feat(cash): implement client delete record

5c500b6

This commit implements the client-side for deleting a cash record.  It
simply adds a new value to the dropdown that can be clicked to remove
the record.

TODO - add end-to-end tests.

Closes #2159.

bors bot added a commit that referenced this issue


          Merge #2188

c1869f4

2188: feature: delete records r=DedrickEnc a=jniles

This PR implements  deleting cash payments following the proposal in #2044 and the design discussed in #2159.  It does much of the heavy lifting for the other two delete issues - vouchers (#2161) and invoices (#2160).

TODO:
 - [x] End to End Tests
 - [x] Delete Invoices #2160.
 - [x] Delete Vouchers #2161.

Collaborator Author

jniles commented Oct 16, 2017

Closed in #2188.

jniles closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment