-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Design: Deleting Invoices #2160
Labels
Comments
@jniles |
It makes it much easier to write a single controller on the client. |
jniles
added a commit
that referenced
this issue
Oct 10, 2017
This commit polishes the client side code for deleting records from the registries. It also ensure the delete integration tests for invoices reference the correct invoice. Closes #2160.
jniles
added a commit
that referenced
this issue
Oct 11, 2017
This commit polishes the client side code for deleting records from the registries. It also ensure the delete integration tests for invoices reference the correct invoice. Closes #2160.
jniles
added a commit
that referenced
this issue
Oct 13, 2017
This commit polishes the client side code for deleting records from the registries. It also ensure the delete integration tests for invoices reference the correct invoice. Closes #2160.
bors bot
added a commit
that referenced
this issue
Oct 16, 2017
2188: feature: delete records r=DedrickEnc a=jniles This PR implements deleting cash payments following the proposal in #2044 and the design discussed in #2159. It does much of the heavy lifting for the other two delete issues - vouchers (#2161) and invoices (#2160). TODO: - [x] End to End Tests - [x] Delete Invoices #2160. - [x] Delete Vouchers #2161.
Closed in #2188. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This issue covers the design for deleting Invoices using the proposal described in #2044.
Design
Deleting invoices will be performed from the Invoice Registry and the Posting Journal (via the transaction edit modal). It is not allowed on posted records. A deleted invoice will remove the lines from the
posting_journal
,invoice
,invoice_item
,invoice_billing_service
, andinvoice_subsidy
. It will also remove therecord_uuid
from thedocument_map
.There are some conditional rules on this operation:
The steps to implement this are:
HTTP DELETE /transactions/:uuid
that will determine if the transaction is a cash payment, voucher, or invoice.safelyDeleteInvoice(uuid)
in thefinance/patientInvoice.js.
module.The text was updated successfully, but these errors were encountered: