Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide title accounts in General Ledger by default #2348

Closed
jniles opened this issue Dec 5, 2017 · 1 comment · Fixed by #2455
Closed

Hide title accounts in General Ledger by default #2348

jniles opened this issue Dec 5, 2017 · 1 comment · Fixed by #2455
Assignees
@jniles
Labels
proposal

Comments

@jniles
Copy link
Collaborator

jniles commented Dec 5, 2017

The General Ledger provides a global view of all accounts and the balances for those accounts for the enterprise. However, it doesn't distinguish between title accounts and non-title accounts. See the screenshot below:

titleaccountsingeneralledger
Fig 1: The underlined accounts are title accounts

By default, the General Ledger should hide title accounts. If a user wants to show them, they could toggle an option on dropdown menu to show the title accounts. Furthermore, if the accounts are visible, they should clearly indicate they are title accounts by:

  1. Not having the "actions" dropdown on them.
  2. Being rendered in bold.
  3. The "balances" should be the totals of all child accounts, if they exist.
@jniles jniles added the proposal label Dec 5, 2017
@jniles jniles mentioned this issue Dec 5, 2017
Closed
@DedrickEnc DedrickEnc self-assigned this Dec 5, 2017
@jniles jniles assigned jniles and unassigned DedrickEnc Jan 15, 2018
@jniles
Copy link
Collaborator Author

jniles commented Jan 15, 2018

I'll take this.

jniles added a commit to jniles/bhima that referenced this issue Jan 15, 2018
@jniles
fix(General Ledger): identify title accounts
b49ff7a 
This commit fixes the general ledger by rendering the title accounts in
bold and removing the option to download their account slips.  I've also
optimized the GL by removing dead code and using ui-grid's native tools
instead of multiple cell templates.

Closes IMA-WorldHealth#2348.
@jniles jniles mentioned this issue Jan 15, 2018
Merged
bors bot added a commit that referenced this issue Jan 19, 2018
@bors
Merge #2454 #2455
6aa97c3 
2454: feat(exchange): add the current exchange rate r=jniles a=jniles

This commit adds the current exchange rate to the exchange rate modal
for reference.  This feature was requested by our clients at HEV.

![exchangerateupdates](https://user-images.githubusercontent.com/896472/34944109-92731706-f9fe-11e7-9ec6-a208c434bf81.PNG)
_Fig 1: Show Exchange Rate on Modal_

Closes #2387.

2455: fix(General Ledger): identify title accounts r=jniles a=jniles

This commit fixes the general ledger by rendering the title accounts in bold and removing the option to download their account slips.  I've also optimized the GL by removing dead code and using ui-grid's native tools instead of multiple cell templates.

![titleaccountbold](https://user-images.githubusercontent.com/896472/34944090-80d30cae-f9fe-11e7-9b4a-07a5ca9da92c.PNG)
_Fig 1: Example of Bold Titles_

Closes #2348.
@bors bors bot closed this as completed in #2455 Jan 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jniles jniles

Labels
proposal
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(General Ledger): identify title accounts jniles/bhima
2 participants
@jniles @DedrickEnc