You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Using the currency filter on the client, which uses spaces to render the 1000s place. Like this: 1 000 000,00FC.
Using the handlebars currency helper on the server, based on accounting-js. This one renders 1000s with a decimal point. Like this: 1.000.000,00FC.
We should use one or the other. In my view, the second option is much more readable. It wouldn't break the currency over two lines if there is a lack of space, and it doesn't look like two different numbers sitting close together. See below: Fig 1: Decimal Point 1000s separator
Unfortunately, I cannot find any guidance online as to which is the correct one for the CDF. Could we just use the second option? What do you think @IMA-WorldHealth/bhima-core ?
The text was updated successfully, but these errors were encountered:
This commit uses a decimal point instead of white space to separate the
FCs thousands place. It makes the currency much more readable on the
client.
ClosesIMA-WorldHealth#2371.
2372: fix(currency): use decimal point 1000s place FC r=DedrickEnc a=jniles
This commit uses a decimal point instead of white space to separate the
FCs thousands place. It makes the currency much more readable on the
client.
Closes#2371.
We currently have two ways of rendering currency:
currency
filter on the client, which uses spaces to render the 1000s place. Like this:1 000 000,00FC
.accounting-js
. This one renders 1000s with a decimal point. Like this:1.000.000,00FC
.We should use one or the other. In my view, the second option is much more readable. It wouldn't break the currency over two lines if there is a lack of space, and it doesn't look like two different numbers sitting close together. See below:
Fig 1: Decimal Point 1000s separator
Unfortunately, I cannot find any guidance online as to which is the correct one for the CDF. Could we just use the second option? What do you think @IMA-WorldHealth/bhima-core ?
The text was updated successfully, but these errors were encountered: