Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use decimal points as 1000s separators for FC #2371

Closed
jniles opened this issue Dec 9, 2017 · 0 comments
Closed

Use decimal points as 1000s separators for FC #2371

jniles opened this issue Dec 9, 2017 · 0 comments
Labels
proposal

Comments

@jniles
Copy link
Collaborator

jniles commented Dec 9, 2017

We currently have two ways of rendering currency:

  1. Using the currency filter on the client, which uses spaces to render the 1000s place. Like this: 1 000 000,00FC.
  2. Using the handlebars currency helper on the server, based on accounting-js. This one renders 1000s with a decimal point. Like this: 1.000.000,00FC.

We should use one or the other. In my view, the second option is much more readable. It wouldn't break the currency over two lines if there is a lack of space, and it doesn't look like two different numbers sitting close together. See below:
decimalcurrency
Fig 1: Decimal Point 1000s separator

Unfortunately, I cannot find any guidance online as to which is the correct one for the CDF. Could we just use the second option? What do you think @IMA-WorldHealth/bhima-core ?
@jniles jniles added the proposal label Dec 9, 2017
jniles added a commit to jniles/bhima that referenced this issue Dec 9, 2017
@jniles
fix(currency): use decimal point 1000s place FC
d93dc05 
This commit uses a decimal point instead of white space to separate the
FCs thousands place.  It makes the currency much more readable on the
client.

Closes IMA-WorldHealth#2371.
@jniles jniles mentioned this issue Dec 9, 2017
Merged
bors bot added a commit that referenced this issue Dec 9, 2017
@bors
Merge #2372
0931cda 
2372: fix(currency): use decimal point 1000s place FC r=DedrickEnc a=jniles

This commit uses a decimal point instead of white space to separate the
FCs thousands place.  It makes the currency much more readable on the
client.

Closes #2371.
@bors bors bot closed this as completed in #2372 Dec 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
proposal
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jniles