Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stock Entry does not let you delete rows #2492

Closed
jniles opened this issue Feb 2, 2018 · 0 comments · Fixed by #2509
Closed

Stock Entry does not let you delete rows #2492

jniles opened this issue Feb 2, 2018 · 0 comments · Fixed by #2509
Assignees
@jeremielodi
Labels
Bug

Comments

@jniles
Copy link
Collaborator

jniles commented Feb 2, 2018

There is a bug in stock entry (#!/stock/entry) that does not let a user delete rows that they just created with the "add a row" button. No error is echoed to the client.
@jniles jniles added the Bug label Feb 2, 2018
@jeremielodi jeremielodi self-assigned this Feb 3, 2018
@jeremielodi jeremielodi mentioned this issue Feb 3, 2018
Merged
jniles added a commit to jeremielodi/bhima-2.X that referenced this issue Feb 7, 2018
@jniles
fix(stock): force refresh grid index
5849d99 
This commit forces the grid to use the correct index by referencing it
in the HTML.  Previously, grid cells were being reused instead of being
updated.  By referencing the index directly, the grid responds with the
correct index.

Closes IMA-WorldHealth#2492.
bors bot added a commit that referenced this issue Feb 7, 2018
@bors
Merge #2509
ae6463b 
2509: feact(stock entry) delete grid row r=jniles a=jeremielodi

closes #2492
@bors bors bot closed this as completed in #2509 Feb 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeremielodi jeremielodi

Labels
Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feact(stock entry) delete grid row jeremielodi/bhima-2.X
2 participants
@jniles @jeremielodi