Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trial Balance does not limit to most recent fiscal year #2568

Closed
jniles opened this issue Feb 24, 2018 · 0 comments
Closed

Trial Balance does not limit to most recent fiscal year #2568

jniles opened this issue Feb 24, 2018 · 0 comments
Assignees
@jniles
Labels
Bug

Comments

@jniles
Copy link
Contributor

jniles commented Feb 24, 2018

The Trial Balance groups the entire period totals table when calculating the balance_before column in the Trial Balance view. While is acceptable if all data is correct, if previous fiscal years have corrupted data, it perpetuates the data corruption.

This causes the balance_before to be different from the balance reported by both the General Ledger and the Account Statement. We should bring the Trial Balance in line with those two reports.
@jniles jniles added the Bug label Feb 24, 2018
@jniles jniles self-assigned this Feb 24, 2018
jniles added a commit to jniles/bhima that referenced this issue Feb 24, 2018
@jniles
fix(Trial Balance): limit lookup to FY
f5d72d0 
This commit limits the Trial Balance lookup to only oldest fiscal year.

Closes IMA-WorldHealth#2568.
@jniles jniles mentioned this issue Feb 24, 2018
Merged
jniles added a commit to jniles/bhima that referenced this issue Feb 24, 2018
@jniles
fix(Trial Balance): limit lookup to FY
66edb9f 
This commit limits the Trial Balance lookup to only oldest fiscal year.

Closes IMA-WorldHealth#2568.
jniles added a commit to jniles/bhima that referenced this issue Feb 27, 2018
@jniles
fix(Trial Balance): limit lookup to FY
227097a 
This commit limits the Trial Balance lookup to only oldest fiscal year.
It also fixes a grouping bug that summed the before total an extra time.
This lead to N * beginning_balance being reported for N transactions.

Closes IMA-WorldHealth#2568.
jniles added a commit to jniles/bhima that referenced this issue Feb 28, 2018
@jniles
fix(Trial Balance): limit lookup to FY
16ce3c3 
This commit limits the Trial Balance lookup to only oldest fiscal year.
It also fixes a grouping bug that summed the before total an extra time.
This lead to N * beginning_balance being reported for N transactions.

Closes IMA-WorldHealth#2568.
bors bot added a commit that referenced this issue Feb 28, 2018
@bors
Merge #2569
12ff2ba 
2569: fix(Trial Balance): limit lookup to FY r=mbayopanda a=jniles

This commit limits the Trial Balance lookup to only oldest fiscal year.

Closes #2568.
@bors bors bot closed this as completed in #2569 Feb 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jniles jniles

Labels
Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jniles