fix(Trial Balance): limit lookup to FY #2569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jniles
force-pushed
the
fix-trial-balance-scope
branch
from
f5d72d0
to
66edb9f
Compare
jniles
force-pushed
the
fix-trial-balance-scope
branch
from
66edb9f
to
227097a
Compare
This commit limits the Trial Balance lookup to only oldest fiscal year. It also fixes a grouping bug that summed the before total an extra time. This lead to N * beginning_balance being reported for N transactions. Closes Third-Culture-Software#2568.
jniles
force-pushed
the
fix-trial-balance-scope
branch
from
227097a
to
16ce3c3
Compare
mbayopanda
reviewed
Feb 28, 2018
| GROUP BY u.account_id; | ||
|
|
||
| SELECT account_id, account.number AS number, account.label AS label, | ||
| balance_before, debit_equiv, credit_equiv, | ||
| balance_before + debit_equiv - credit_equiv AS balance_final | ||
| FROM ( | ||
| SELECT posting_journal.account_id, SUM(totals.balance_before) AS balance_before, SUM(debit_equiv) AS debit_equiv, | ||
| SELECT posting_journal.account_id, MAX(totals.balance_before) AS balance_before, SUM(debit_equiv) AS debit_equiv, |
There was a problem hiding this comment.
Could you fix this MAX if it is required, in my test i cannot see the error with MAX
|
bors r+ |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit limits the Trial Balance lookup to only oldest fiscal year.
Closes #2568.