fix(services): repair flaky e2e test #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jniles
force-pushed
the
bug-flaky-services-test
branch
from
8ccdefa
to
7bf324a
Compare
This commit fixes a flaky end to end test that could randomly choose a non-existent service to update.
jniles
force-pushed
the
bug-flaky-services-test
branch
from
7bf324a
to
07240fa
Compare
bors bot
added a commit
that referenced
this pull request
Dec 10, 2018
3456: Update snyk to the latest version 🚀 r=jniles a=greenkeeper[bot] ## The dependency [snyk](https://github.com/snyk/snyk) was updated from `1.116.1` to `1.116.3`. This version is **not covered** by your **current version range**. If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update. --- <details> <summary>Release Notes for v1.116.3</summary> <h2><a href="https://urls.greenkeeper.io/snyk/snyk/compare/v1.116.2...v1.116.3">1.116.3</a> (2018-12-10)</h2> <h3>Bug Fixes</h3> <ul> <li>add tests for missing package name (<a href="https://urls.greenkeeper.io/snyk/snyk/commit/d2cfcb0">d2cfcb0</a>)</li> </ul> </details> <details> <summary>Commits</summary> <p>The new version differs by 4 commits.</p> <ul> <li><a href="https://urls.greenkeeper.io/snyk/snyk/commit/56726e196f718249a365ccd749a01f8d09410209"><code>56726e1</code></a> <code>Merge pull request #301 from snyk/fix/test_updater</code></li> <li><a href="https://urls.greenkeeper.io/snyk/snyk/commit/d2cfcb001fcfad001e81d8742040acc0a2058563"><code>d2cfcb0</code></a> <code>fix: add tests for missing package name</code></li> <li><a href="https://urls.greenkeeper.io/snyk/snyk/commit/61889f8f0e9b3334578f81d91de529cdfb7dab6a"><code>61889f8</code></a> <code>Merge pull request #298 from snyk/fix/gpg-issue-with-dockerfiles</code></li> <li><a href="https://urls.greenkeeper.io/snyk/snyk/commit/d04bc43af7884199937b75002c553c758dc5702e"><code>d04bc43</code></a> <code>fix: gpg complains on non-tty mode in docker building process</code></li> </ul> <p>See the <a href="https://urls.greenkeeper.io/snyk/snyk/compare/e9b996e73c5517588bc1cc8ed3553d7ded194ba7...56726e196f718249a365ccd749a01f8d09410209">full diff</a></p> </details> <details> <summary>FAQ and help</summary> There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new). </details> --- Your [Greenkeeper](https://greenkeeper.io) bot 🌴 Co-authored-by: greenkeeper[bot] <greenkeeper[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a flaky end to end test that could randomly choose a non-existent service to update.
Hi! Thank you for contributing!
Before submitting this pull request, please verify that you have:
For a more detailed checklist, see the official review checklist
that this PR will be evaluated against.
Ensuring that the above checkboxes are completed will help speed the review process
and help build a stronger application. Thanks!