Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(refactor) Change all account typeaheads to uiSelects #727

Closed
jniles opened this issue Sep 14, 2016 · 2 comments
Closed

(refactor) Change all account typeaheads to uiSelects #727

jniles opened this issue Sep 14, 2016 · 2 comments
Assignees
Labels

Comments

@jniles
Copy link
Collaborator

jniles commented Sep 14, 2016

The ui-select bridges a nice gap between typeahead and a dropdown select. I propose that we refactor all our account uib-typeaheads to use ui-selects. The testing hooks already exist, so this is purely a UI change.

@DedrickEnc @mbayopanda what do you think?

@jniles jniles added this to the Future milestone Sep 14, 2016
@DedrickEnc
Copy link
Contributor

I agree, it is natural to use a right component for a right purpose.

@jniles
Copy link
Collaborator Author

jniles commented Sep 26, 2016

I'll take this.

@jniles jniles self-assigned this Sep 26, 2016
jniles pushed a commit to jniles/bhima that referenced this issue Sep 26, 2016
This commit removes all account `uib-typeahead`s from the application
and replaces them with `ui-select` components for better usability.  All
tests have been updated accordingly.

It also removes a large number of unused directives and templates from
the directives/components/partials folders.  Any regression should be
reported (but tests pass)!

Closes IMA-WorldHealth#727.
jniles pushed a commit to jniles/bhima that referenced this issue Sep 26, 2016
This commit removes all account `uib-typeahead`s from the application
and replaces them with `ui-select` components for better usability.  All
tests have been updated accordingly.

It also removes a large number of unused directives and templates from
the directives/components/partials folders.  Any regression should be
reported (but tests pass)!

Closes IMA-WorldHealth#727.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants