(refactor) account uiSelects #745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 26, 2016 22:13
This commit removes all unused components from the repository. These components were either incomplete or unused.
This commit removes all account `uib-typeahead`s from the application and replaces them with `ui-select` components for better usability. All tests have been updated accordingly. It also removes a large number of unused directives and templates from the directives/components/partials folders. Any regression should be reported (but tests pass)! Closes Third-Culture-Software#727.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes all unused components, directives, and templates from the repository. These components were either incomplete or unused. Any regression should be reported (but tests pass)!
This commit removes all account
uib-typeaheads from the application and replaces them withui-selectcomponents for better usability. All tests have been updated accordingly.Finally, a few modules have better error handling with
Notify.handleError. Some modules, such as Debtor Groups, did not have proper error handling on all their HTTP requests.Closes #727.
Thank you for contributing!
Before submitting this pull request, please verify that you have:
For a more detailed checklist, see the official review checklist that this PR will be evaluated against.
Ensuring that the above checkboxes are completed will help speed the review process and help build a stronger application. Thanks!