Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Feature) Optional (important) field selection #933

Closed
sfount opened this issue Nov 24, 2016 · 2 comments · Fixed by #2278
Closed

(Feature) Optional (important) field selection #933

sfount opened this issue Nov 24, 2016 · 2 comments · Fixed by #2278

Comments

@sfount
Copy link
Contributor

sfount commented Nov 24, 2016

Currently in service management cost and profit centers can be assigned using a normal select - they are optional fields but are essential to the correct functioning of the accounting.

  • Once a cost or profit center is allocated they can not be removed as the select has no null value, this is a bad user experience
  • No logic or rules exist considering if you can change a cost or profit center and the implications of that

I suggest a component for important but optional data that allows the user to 'Add' the field, making the choice to add or remove the configuration makes it clear that it is optional.

Service management - optional fields not added
service

Service management - add cost center configuration
service cost center

@jniles
Copy link
Collaborator

jniles commented Nov 25, 2016

So, if I'm thinking about this correctly, it would look like this in code?

<bh-hidden-field label="SERVICES.COST_CENTER">
  <div class="form-group">
      <label> ... </label>
       <input .... >
   </div>
</bh-hidden-field>

Something like that?

@jniles
Copy link
Collaborator

jniles commented Nov 5, 2017

I'll work on this. It will clean up our reports interface greatly.

jniles added a commit to jniles/bhima that referenced this issue Nov 5, 2017
This commit implements the `bhHiddenField` component which hides any
transcluded HTML behind a toggle and lets the user decide when to show
it and to hide it after.  The use case is for option fields in forms
that do not need to be considered by default.  For example, many reports
have complex options that should not be presented on the outset, but can
instead by added in later.

Closes IMA-WorldHealth#933.
jniles added a commit to jniles/bhima that referenced this issue Nov 6, 2017
This commit implements the `bhHiddenField` component which hides any
transcluded HTML behind a toggle and lets the user decide when to show
it and to hide it after.  The use case is for option fields in forms
that do not need to be considered by default.  For example, many reports
have complex options that should not be presented on the outset, but can
instead by added in later.

Closes IMA-WorldHealth#933.
jniles added a commit to jniles/bhima that referenced this issue Nov 9, 2017
This commit implements the `bhHiddenField` component which hides any
transcluded HTML behind a toggle and lets the user decide when to show
it and to hide it after.  The use case is for option fields in forms
that do not need to be considered by default.  For example, many reports
have complex options that should not be presented on the outset, but can
instead by added in later.

Closes IMA-WorldHealth#933.
jniles added a commit to jniles/bhima that referenced this issue Nov 11, 2017
This commit implements the `bhHiddenField` component which hides any
transcluded HTML behind a toggle and lets the user decide when to show
it and to hide it after.  The use case is for option fields in forms
that do not need to be considered by default.  For example, many reports
have complex options that should not be presented on the outset, but can
instead by added in later.

Closes IMA-WorldHealth#933.
jniles added a commit to jniles/bhima that referenced this issue Nov 16, 2017
This commit implements the `bhHiddenField` component which hides any
transcluded HTML behind a toggle and lets the user decide when to show
it and to hide it after.  The use case is for option fields in forms
that do not need to be considered by default.  For example, many reports
have complex options that should not be presented on the outset, but can
instead by added in later.

Closes IMA-WorldHealth#933.
jniles added a commit to jniles/bhima that referenced this issue Nov 16, 2017
This commit implements the `bhHiddenField` component which hides any
transcluded HTML behind a toggle and lets the user decide when to show
it and to hide it after.  The use case is for option fields in forms
that do not need to be considered by default.  For example, many reports
have complex options that should not be presented on the outset, but can
instead by added in later.

Closes IMA-WorldHealth#933.
bors bot added a commit that referenced this issue Nov 16, 2017
2278: feat: implement bhHiddenField r=DedrickEnc a=jniles

This commit implements the `bhHiddenField` component which hides any transcluded HTML behind a toggle and lets the user decide when to show it and to hide it after.  The use case is for option fields in forms that do not need to be considered by default.  For example, many reports have complex options that should not be presented on the outset, but can instead by added in later.

Closes #933.

![clientsreportclosed](https://user-images.githubusercontent.com/896472/32426507-81521b88-c2c3-11e7-957f-bc9240fafa0d.PNG)
_Fig 1: Closed Hidden Field_

![clientsreportopen](https://user-images.githubusercontent.com/896472/32426508-82157466-c2c3-11e7-877f-009598a09204.PNG)
_Fig 2: Open Hidden Field_
@bors bors bot closed this as completed in #2278 Nov 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants