perf(stock): fix the exit helper

Improves performance during stock movement creation and lookup in the helpers.
IMA-WorldHealth · Mar 4, 2022 · 910d718 · 910d718
1 parent 22a3cf1
commit 910d718
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 7 deletions.
diff --git a/client/src/modules/stock/StockExitForm.service.js b/client/src/modules/stock/StockExitForm.service.js
@@ -371,7 +371,7 @@ function StockExitFormService(
    */
   StockExitForm.prototype.setPatientDistribution = function setPatientDistribution(patient) {
     this.details.entity_uuid = patient.uuid;
-    this.details.invoice_uuid = patient.invoice.uuid;
+    this.details.invoice_uuid = patient.invoice.details.uuid;
     this.details.flux_id = TO_PATIENT;
     this.store.clear();
 

diff --git a/client/src/modules/stock/StockExitFormHelper.service.js b/client/src/modules/stock/StockExitFormHelper.service.js
@@ -27,14 +27,12 @@ function StockExitFormHelperService($q, $translate, Patients, Invoices, Services
 
     // load the required information for the patient description
     const queries = $q.all([
-      Patients.read(null, { uuid : details.entity_uuid }),
-      Invoices.read(null, { uuid : details.invoice_uuid }),
+      Patients.read(details.entity_uuid),
+      Invoices.read(details.invoice_uuid),
     ]);
 
     return queries
-      .then(([patients, invoices]) => {
-        const [patient] = patients;
-        const [invoice] = invoices;
+      .then(([patient, invoice]) => {
 
         Object.assign(i18nKeys, {
           patient : patient.display_name.concat(` (${patient.reference})`),
@@ -56,7 +54,7 @@ function StockExitFormHelperService($q, $translate, Patients, Invoices, Services
    */
   function getDescriptionForService(details, i18nKeys) {
     // load the required information for the service description
-    return Services.read(null, { uuid : details.entity_uuid })
+    return Services.read(details.entity_uuid)
       .then(([{ name }]) => {
 
         Object.assign(i18nKeys, { service : name });

diff --git a/server/controllers/stock/index.js b/server/controllers/stock/index.js
@@ -458,6 +458,18 @@ async function createMovement(req, res, next) {
       }
     }
 
+    // get unit costs from stock_value
+    const inventoryUuids = params.lots.map(l => db.bid(l.inventory_uuid));
+    const unitCosts = await db.exec(
+      'SELECT BUID(inventory_uuid) as inventory_uuid, wac FROM stock_value WHERE inventory_uuid in (?);',
+      [inventoryUuids]);
+
+    const unitCostMap = new Map(unitCosts.map(cost => [cost.inventory_uuid, cost.wac]));
+
+    params.lots.forEach(lot => {
+      lot.unit_cost = unitCostMap.get(lot.inventory_uuid);
+    });
+
     // NOTE(@jniles) - the id here is the period id, not the fiscal year id.
     const periodId = (await Fiscal.lookupFiscalYearByDate(params.date)).id;
     params.period_id = periodId;