Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(refactor) Journal search #1436

Closed
sfount opened this issue Mar 28, 2017 · 1 comment
Closed

(refactor) Journal search #1436

sfount opened this issue Mar 28, 2017 · 1 comment
Assignees
@sfount
Labels
design Refactor

Comments

@sfount
Copy link
Contributor

sfount commented Mar 28, 2017

I propose that we split the journal search modal/ functionality into 2 (initially) different sections, default and standard filters.

Default filters will consist of:

  • Date range

    • Today
    • Yesterday
    • This week
    • Last week
    • This month
    • Last month
    • This year
    • Last year
    • All time

  • Transaction State

    • Posted
    • Not posted

The modal will be split into sections using a tab interface - default and standard filters.

  1. Clean up current search modal, fixing style issues
  2. Define UI/ UX concept for default vs. normal filters
  3. Implement UI separation for filter bar
  4. Split search modal into multiple sections (using proposed tab structure)
  5. Optimise queries to ensure that posting journal requests do not crash on lower end hardware
@sfount sfount self-assigned this Mar 28, 2017
jniles pushed a commit to jniles/bhima that referenced this issue Apr 19, 2017
feat(journal): default limit to today's records
a4eb123 
This commit extends the hacks done for other registries to the Posting Journal, so that it defaults
to today's records as a search.  This should speed up the initial startup of the module considerably
while we develop a better representation of our filters on the client.

Addresses IMA-WorldHealth#1436 in a hacky way.
@jniles jniles mentioned this issue Apr 19, 2017
Merged
4 tasks
jniles pushed a commit to jniles/bhima that referenced this issue Apr 19, 2017
feat(journal): default limit to today's records
0336401 
This commit extends the hacks done for other registries to the Posting Journal, so that it defaults
to today's records as a search.  This should speed up the initial startup of the module considerably
while we develop a better representation of our filters on the client.

Addresses IMA-WorldHealth#1436 in a hacky way.
jniles pushed a commit to jniles/bhima that referenced this issue Apr 20, 2017
feat(journal): default limit to today's records
442ce82 
This commit extends the hacks done for other registries to the Posting Journal, so that it defaults
to today's records as a search.  This should speed up the initial startup of the module considerably
while we develop a better representation of our filters on the client.

Addresses IMA-WorldHealth#1436 in a hacky way.
jniles pushed a commit to jniles/bhima that referenced this issue Apr 20, 2017
feat(journal): default limit to today's records
59a0986 
This commit extends the hacks done for other registries to the Posting Journal, so that it defaults
to today's records as a search.  This should speed up the initial startup of the module considerably
while we develop a better representation of our filters on the client.

Addresses IMA-WorldHealth#1436 in a hacky way.
jniles pushed a commit to jniles/bhima that referenced this issue Apr 20, 2017
feat(journal): default limit to today's records
dea71fe 
This commit extends the hacks done for other registries to the Posting Journal, so that it defaults
to today's records as a search.  This should speed up the initial startup of the module considerably
while we develop a better representation of our filters on the client.

Addresses IMA-WorldHealth#1436 in a hacky way.
jniles pushed a commit to jniles/bhima that referenced this issue Apr 20, 2017
feat(journal): default limit to today's records
b2578f2 
This commit extends the hacks done for other registries to the Posting Journal, so that it defaults
to today's records as a search.  This should speed up the initial startup of the module considerably
while we develop a better representation of our filters on the client.

Addresses IMA-WorldHealth#1436 in a hacky way.
jniles pushed a commit to jniles/bhima that referenced this issue Apr 20, 2017
feat(journal): default limit to today's records
97f5359 
This commit extends the hacks done for other registries to the Posting Journal, so that it defaults
to today's records as a search.  This should speed up the initial startup of the module considerably
while we develop a better representation of our filters on the client.

Addresses IMA-WorldHealth#1436 in a hacky way.
jniles added a commit that referenced this issue Apr 20, 2017
@jniles
feat(journal): default limit to today's records (#1523)
57528e1 
This commit extends the hacks done for other registries to the Posting Journal, so that it defaults
to today's records as a search.  This should speed up the initial startup of the module considerably
while we develop a better representation of our filters on the client.

Addresses #1436 in a hacky way.
@sfount
Copy link
Contributor Author

sfount commented May 24, 2017

I believe this proposal was implemented and merged in #1566

@sfount sfount closed this as completed May 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sfount sfount

Labels
design Refactor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sfount