Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(bug) Latest ui-router breaks $state.param changes #1589

Closed
jniles opened this issue May 4, 2017 · 1 comment
Closed

(bug) Latest ui-router breaks $state.param changes #1589

jniles opened this issue May 4, 2017 · 1 comment
Labels

Comments

@jniles
Copy link
Collaborator

jniles commented May 4, 2017

The Angular UI Router project just released version 1.0.0. We had upgraded to the first release candidate (RC1), but it seems their $state.param processing has changed in the latest release.

In particular, ui-sref and $state.go() both do not refresh their parameters after an initial call. There may be a way to coerce this using ui-sref-opts and a similar method for $state.go, but it is undocumented and I do not have enough time to try each permutation of options. Many of the $stateParamDeclaration options I have already tried with no success.

I propose we revert to a stable ui-router version and calmly upgrade. Ironically, for us this will be rc-1. It is this issue that has been breaking Travis.

@jniles jniles added the Bug label May 4, 2017
@jniles
Copy link
Collaborator Author

jniles commented May 4, 2017

We should continue to watch the ui-router issue tracker to see if anyone else runs into these issues.

jniles pushed a commit to jniles/bhima that referenced this issue May 4, 2017
The latest ui-router (v1.0.0) creates breaking changes in state changes that do not seem to be
documented anywhere.  This is a quick downgrade to allow seamless development while we debug the
issue.

Closes IMA-WorldHealth#1589
jniles added a commit that referenced this issue May 4, 2017
The latest ui-router (v1.0.0) creates breaking changes in state changes that do not seem to be
documented anywhere.  This is a quick downgrade to allow seamless development while we debug the
issue.

Closes #1589
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant