Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(refactor) Improvements to Fiscal Year #1646

Closed
5 tasks done
jniles opened this issue May 12, 2017 · 1 comment
Closed
5 tasks done

(refactor) Improvements to Fiscal Year #1646

jniles opened this issue May 12, 2017 · 1 comment
Assignees
@jniles
Labels
Refactor

Comments

@jniles
Copy link
Contributor

jniles commented May 12, 2017 •
edited
Loading

In order to have opening balances properly calculated, we need to address how to open, close, and adjust fiscal years. The Fiscal Year module is showing its age, and needs to benefit from a few cosmetic improvements before the logic can be cleanly addressed.
@jniles jniles self-assigned this May 12, 2017
jniles added a commit to jniles/bhima that referenced this issue May 12, 2017
@jniles
refactor(fiscal): best practices for closing
e0ee9da 
This commit updates the Fiscal Year module with the current best coding
practices.  It specifically targets the closing fiscal year code and
updates it with the following changes:
 1. The translate directive is used instead of the translate filter
 2. The bhAccountSelect is used instead of a custom ui-select
 3. The modal uses a headercrumb(tm)
 4. Removed bhFormDefaults from the form.

This commit addresses most of the points in IMA-WorldHealth#1646 for closing a fiscal
year.  Tests have been updated accordingly. The rest of the fiscal year
modules should be updated in a similar fashion.
@jniles jniles mentioned this issue May 12, 2017
Merged
4 tasks
jniles added a commit to jniles/bhima that referenced this issue May 12, 2017
@jniles
refactor(fiscal): best practices for closing
cb35b01 
This commit updates the Fiscal Year module with the current best coding
practices.  It specifically targets the closing fiscal year code and
updates it with the following changes:
 1. The translate directive is used instead of the translate filter
 2. The bhAccountSelect is used instead of a custom ui-select
 3. The modal uses a headercrumb(tm)
 4. Removed bhFormDefaults from the form.

This commit addresses most of the points in IMA-WorldHealth#1646 for closing a fiscal
year.  Tests have been updated accordingly. The rest of the fiscal year
modules should be updated in a similar fashion.
jniles added a commit to jniles/bhima that referenced this issue May 19, 2017
@jniles
refactor(fiscal): best practices for closing
9dc8405 
This commit updates the Fiscal Year module with the current best coding
practices.  It specifically targets the closing fiscal year code and
updates it with the following changes:
 1. The translate directive is used instead of the translate filter
 2. The bhAccountSelect is used instead of a custom ui-select
 3. The modal uses a headercrumb(tm)
 4. Removed bhFormDefaults from the form.

This commit addresses most of the points in IMA-WorldHealth#1646 for closing a fiscal
year.  Tests have been updated accordingly. The rest of the fiscal year
modules should be updated in a similar fashion.
jniles added a commit to jniles/bhima that referenced this issue May 22, 2017
@jniles
refactor(fiscal): best practices for closing
dc8e0df 
This commit updates the Fiscal Year module with the current best coding
practices.  It specifically targets the closing fiscal year code and
updates it with the following changes:
 1. The translate directive is used instead of the translate filter
 2. The bhAccountSelect is used instead of a custom ui-select
 3. The modal uses a headercrumb(tm)
 4. Removed bhFormDefaults from the form.

This commit addresses most of the points in IMA-WorldHealth#1646 for closing a fiscal
year.  Tests have been updated accordingly. The rest of the fiscal year
modules should be updated in a similar fashion.
sfount pushed a commit that referenced this issue May 23, 2017
@jniles @sfount
refactor(fiscal): best practices for closing
d8d6f80 
This commit updates the Fiscal Year module with the current best coding
practices.  It specifically targets the closing fiscal year code and
updates it with the following changes:
 1. The translate directive is used instead of the translate filter
 2. The bhAccountSelect is used instead of a custom ui-select
 3. The modal uses a headercrumb(tm)
 4. Removed bhFormDefaults from the form.

This commit addresses most of the points in #1646 for closing a fiscal
year.  Tests have been updated accordingly. The rest of the fiscal year
modules should be updated in a similar fashion.
@jniles jniles mentioned this issue Jul 16, 2017
Closed
@jniles
Copy link
Contributor Author

jniles commented Jul 16, 2017

All these have been progressively tackled in #1627, #1840, and #1650.

@jniles jniles closed this as completed Jul 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jniles jniles

Labels
Refactor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jniles