Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements to the Voucher Registry #2412

Closed
jniles opened this issue Dec 16, 2017 · 2 comments · Fixed by #2610
Closed

Improvements to the Voucher Registry #2412

jniles opened this issue Dec 16, 2017 · 2 comments · Fixed by #2610
Assignees
@jniles
Labels
Bug Refactor

Comments

@jniles
Copy link
Contributor

jniles commented Dec 16, 2017 •
edited
Loading

The voucher registry will be used to validate pretty much all writings for the main cashboxes, the bank accounts, and other account to account transfers. Here are some improvements we should add:

  1. Filter by account number
  2. Filter by Entity Reference.
  3. Filter by Document Reference.

In my experience, the grouping on the column headers is confusing. A much more straightforward way to do grouping is like that in the Posting Journal and Account Statement with an activated button. I propose we remove all column menus for simplicity.

Also, the action column should be hidden in the column configuration page.
@jniles jniles self-assigned this Dec 16, 2017
@jniles
Copy link
Contributor Author

jniles commented Dec 16, 2017

This is critical for some of the validation work we need to put in place at HEV. I'll be working on this today.

jniles added a commit to jniles/bhima that referenced this issue Dec 16, 2017
@jniles
feat(vouchers): filter on account
01ac57e 
This commit implements filtering by account on the voucher search modal.
Contributes to IMA-WorldHealth#2412.
@jniles jniles mentioned this issue Dec 16, 2017
Merged
bors bot added a commit that referenced this issue Dec 16, 2017
@bors
Merge #2416
8ab6c46 
2416: feat(vouchers): filter on account r=jniles a=jniles

This commit implements filtering by account on the voucher search modal.  It also removes some unused imports from the voucher search modal.

Contributes to #2412.
@jniles
Copy link
Contributor Author

jniles commented Dec 22, 2017

Also, a bug: the "receipt" link on the voucher registry is broken.

@jniles jniles added the Bug label Dec 22, 2017
jniles added a commit to jniles/bhima that referenced this issue Mar 21, 2018
@jniles
refactor(vouchers): polish registry
dd30cf2 
This commit polishes the registry by removing the grid grouping values,
updating the code to ES6 and fixing the voucher receipt link.

Closes IMA-WorldHealth#2412.
@jniles jniles mentioned this issue Mar 21, 2018
Merged
jniles added a commit to jniles/bhima that referenced this issue Mar 23, 2018
@jniles
refactor(vouchers): polish registry
4a33c94 
This commit polishes the registry by removing the grid grouping values,
updating the code to ES6 and fixing the voucher receipt link.

Closes IMA-WorldHealth#2412.
bors bot added a commit that referenced this issue Mar 23, 2018
@bors
Merge #2610
d254feb 
2610: refactor(vouchers): polish registry r=jniles a=jniles

This commit polishes the registry by removing the grid grouping values, updating the code to ES6 and fixing the voucher receipt link.

Closes #2412.
bors bot added a commit that referenced this issue Mar 23, 2018
@bors
Merge #2610
de50272 
2610: refactor(vouchers): polish registry r=jniles a=jniles

This commit polishes the registry by removing the grid grouping values, updating the code to ES6 and fixing the voucher receipt link.

Closes #2412.
@bors bors bot closed this as completed in #2610 Mar 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jniles jniles

Labels
Bug Refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(vouchers): polish registry jniles/bhima
1 participant
@jniles