Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The custom date selection should default to the last dates the user put in #2516

Closed
jniles opened this issue Feb 6, 2018 · 0 comments
Closed

The custom date selection should default to the last dates the user put in #2516

jniles opened this issue Feb 6, 2018 · 0 comments
Assignees
@jniles
Labels
Bug

Comments

@jniles
Copy link
Collaborator

jniles commented Feb 6, 2018

Currently, the date selection does not remember the last values that it undertook. See below:

periodselectioncustomizeddoesnotrememberpreviousvalues
Fig 1: These two should have the same dates

This is a really annoying user experience. We should fix this as soon as possible.
@jniles jniles added the Bug label Feb 6, 2018
@jniles jniles self-assigned this Feb 8, 2018
jniles added a commit to jniles/bhima that referenced this issue Feb 8, 2018
@jniles
feat(bhPeriodSelect): preserve custom dates
010e9e2 
This commit ensures that the bhPeriodSelect remembers custom dates if
they are set in the same session.

Closes IMA-WorldHealth#2516.
@jniles jniles mentioned this issue Feb 8, 2018
Merged
bors bot added a commit that referenced this issue Feb 8, 2018
@bors
Merge #2525
ee79b19 
2525: feat(bhPeriodSelect): preserve custom dates r=jniles a=jniles

This commit ensures that the bhPeriodSelect remembers custom dates if they are set in the same session.

Closes #2516.
bors bot added a commit that referenced this issue Feb 8, 2018
@bors
Merge #2525
b5d88c4 
2525: feat(bhPeriodSelect): preserve custom dates r=jniles a=jniles

This commit ensures that the bhPeriodSelect remembers custom dates if they are set in the same session.

Closes #2516.
@bors bors bot closed this as completed in #2525 Feb 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jniles jniles

Labels
Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jniles