-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(Bug) Tree component not populated on login #272
Comments
The issue is that "login" no longer emits a login event via appstate. We can either emit the event using $scope.$on/$broadcast, or use a service to listen for login. Or the SessionService could expose a onLogin() method that calls the tree's loading function whenever the user logs in. What do you think is the best design? |
I like the idea of the session service exposing an I suggest this problem is tackled as follows:
|
3400: Update snyk to the latest version 🚀 r=jniles a=greenkeeper[bot] ## The dependency [snyk](https://github.com/snyk/snyk) was updated from `1.110.2` to `1.111.0`. This version is **not covered** by your **current version range**. If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update. --- <details> <summary>Release Notes for v1.111.0</summary> <h1><a href="https://urls.greenkeeper.io/snyk/snyk/compare/v1.110.2...v1.111.0">1.111.0</a> (2018-11-28)</h1> <h3>Features</h3> <ul> <li>test plugin dep-trees as graphs via new /test-dep-graph API (<a href="https://urls.greenkeeper.io/snyk/snyk/commit/b23d9cc">b23d9cc</a>)</li> </ul> </details> <details> <summary>Commits</summary> <p>The new version differs by 2 commits.</p> <ul> <li><a href="https://urls.greenkeeper.io/snyk/snyk/commit/38f8ab4cfa7850e891c093fd9eb7c3f6422fb357"><code>38f8ab4</code></a> <code>Merge pull request #272 from snyk/feat/send-test-plugin-payload-as-graph</code></li> <li><a href="https://urls.greenkeeper.io/snyk/snyk/commit/b23d9cc196ed6e2ce7fef9847141bcf7fb1720a0"><code>b23d9cc</code></a> <code>feat: test plugin dep-trees as graphs via new /test-dep-graph API</code></li> </ul> <p>See the <a href="https://urls.greenkeeper.io/snyk/snyk/compare/e96ad625e9138a1ebdad91acf714b88709dcfc68...38f8ab4cfa7850e891c093fd9eb7c3f6422fb357">full diff</a></p> </details> <details> <summary>FAQ and help</summary> There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new). </details> --- Your [Greenkeeper](https://greenkeeper.io) bot 🌴 Co-authored-by: greenkeeper[bot] <greenkeeper[bot]@users.noreply.github.com>
Steps to reproduce:
npm run app
superuser
superuser
(The tree is currently in a collapsed state)
Expected behaviour:
The tree routes are populated
Actual behaviour::
The tree is empty
This should be addressed before closing #44 and proves that all of our components need unit tests (as introduced #250)
The text was updated successfully, but these errors were encountered: