Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite the complex journal vouchers tests using page objects #426

Closed
jniles opened this issue May 24, 2016 · 0 comments
Closed

Rewrite the complex journal vouchers tests using page objects #426

jniles opened this issue May 24, 2016 · 0 comments
Assignees

Comments

@jniles
Copy link
Collaborator

jniles commented May 24, 2016

The complex journal voucher page is a very large and complicated page. To make tests easier, it would benefit from protractor's page objects, as suggested in #123.

It appears this page is buggy (see #417). I'll be working in rewriting the tests for this page to use a page object and fixing these bugs.

@jniles jniles self-assigned this May 24, 2016
jniles referenced this issue in jniles/bhima May 25, 2016
This commit adds a page object representation for Complex Journal
Vouchers to facilitate testing.  In accomplishing this, the HTML of
complex journal vouchers is cleaned up to allow faster rendering and
better test selector targets.

Instead of individually selecting `[data-account-row="1"]`, each row is
given an index `[data-row="$index"]`, and used as the basis for all
row-level selects.

Two new features in FormUtilties:
 1. FU.typeahead() to support setting typeahead values
 2. FU.dropdown() to support setting dropdown menus

Closes #426.
@sfount sfount closed this as completed in d984911 May 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant