Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(recommendation) Do not paginate the Posting Journal for 2.x #586

Closed
jniles opened this issue Jul 18, 2016 · 1 comment
Closed

(recommendation) Do not paginate the Posting Journal for 2.x #586

jniles opened this issue Jul 18, 2016 · 1 comment
Labels
Needs Discussion

Comments

@jniles
Copy link
Contributor

jniles commented Jul 18, 2016

Our current posting journal implementation has a Posting Journal that is paginated so that records can appear on multiple pages to try and keep page sizes and rendering small. This introduces UI and programmatic complications when considering other features like printing, filtering, and sorting.

I propose we remove this functionality until it can be properly designed with all other features in mind. Ideally, we should complete the following features:

  1. Printing
  2. Filtering
  3. Sorting
  4. Trial Balance
  5. Editing Transactions

Afterwards, we can reintroduce the pagination feature, taking care to make sure it interacts properly with each implemented feature.

@IMA-WorldHealth/local-contributors What do you think?
@jniles jniles added this to the Posting Journal milestone Jul 18, 2016
@sfount
Copy link
Contributor

sfount commented Jul 19, 2016

I agree that pagination should come last 👍. I think that unless we know the scope of the other features we will not be able to anticipate the requirements for pagination (filtering/ totaling on transactions etc.)

jniles pushed a commit to jniles/bhima that referenced this issue Jul 20, 2016
fix(grid): transition journal to grid services
7600f25 
Closes #376.
Closes IMA-WorldHealth#586.

This commit completes the migration of specific posting journal services
to grid services.  It also removes the ability to paginate the posting
journal as this increases the complexity of the process several fold.

In addition to migrating the service, the GridFiltering service now
provides the option to toggle (inline) filtering on and off.  This could be
useful for power users wanting to filter the view quickly.
@jniles jniles mentioned this issue Jul 20, 2016
Merged
4 tasks
jniles pushed a commit to jniles/bhima that referenced this issue Jul 21, 2016
fix(grid): transition journal to grid services
fc883df 
Closes #376.
Closes IMA-WorldHealth#586.

This commit completes the migration of specific posting journal services
to grid services.  It also removes the ability to paginate the posting
journal as this increases the complexity of the process several fold.

In addition to migrating the service, the GridFiltering service now
provides the option to toggle (inline) filtering on and off.  This could be
useful for power users wanting to filter the view quickly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Needs Discussion
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jniles @sfount