Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move is_medical property from employee to title #7170

Closed
jniles opened this issue Jul 30, 2023 · 2 comments · Fixed by #7227
Closed

Move is_medical property from employee to title #7170

jniles opened this issue Jul 30, 2023 · 2 comments · Fixed by #7227
Assignees
@lomamech
Labels
Human Resources

Comments

@jniles
Copy link
Contributor

jniles commented Jul 30, 2023

Based on #7159 (comment)

Can we move the is_medical to the title_employee table? It seems like is_medical has to do with the employee's job title, not the employee themselves, right?

This issue to be closed by removing the property from the employee table and putting it on the profession, title, or some other table where it is appropriate.
@lomamech
Copy link
Contributor

lomamech commented Aug 4, 2023

Hello @jniles what do you think? Should Pull Request #7159 be merged first just because the creation of the title_employee management module has been fully implemented in this PR? or reimplemented title_employee handling in this new Issue?

@jniles
Copy link
Contributor Author

jniles commented Aug 4, 2023

Hi @lomamech, I don't think this issue should block any code mergers. It is mostly related to code cleanliness.

@lomamech lomamech self-assigned this Aug 25, 2023
lomamech added a commit to lomamech/bhima-2.X that referenced this issue Aug 25, 2023
@lomamech
feature(Set Is Medical from Employee Jobtitle)
34bb7da 
- Remove property is_medical from Employee
- Add property is_medical in table title_employee
- Update modules
closes IMA-WorldHealth#7170
@lomamech lomamech mentioned this issue Aug 25, 2023
Merged
bors bot added a commit that referenced this issue Aug 29, 2023
@bors @lomamech
Merge #7227
1543ff4 
7227: feature(Set Is Medical from Employee Jobtitle) r=jmcameron a=lomamech

- Remove property is_medical from Employee
- Add property is_medical in table title_employee
- Update modules 

Closes #7170.

Co-authored-by: lomamech <lomamech@gmail.com>
@bors bors bot closed this as completed in 73d3ef2 Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lomamech lomamech

Labels
Human Resources
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feature(Set Is Medical from Employee Jobtitle) lomamech/bhima-2.X
2 participants
@jniles @lomamech