Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements to Inventory List #738

Closed
5 of 8 tasks
jniles opened this issue Sep 23, 2016 · 1 comment
Closed
5 of 8 tasks

Improvements to Inventory List #738

jniles opened this issue Sep 23, 2016 · 1 comment
Labels
Refactor

Comments

@jniles
Copy link
Contributor

jniles commented Sep 23, 2016 •
edited
Loading

The inventory list module has not been updated since the initial implementation. Here are some out of date practices that should be updated:

  • The Edit button is really small, and should contain edit text.
  • There is no Delete button. Note: an inventory item should not be able to be deleted if it is used in a transaction or purchase order.
  • The code input should use bhUnique to check that the code is unique
  • The consumable checkbox does not use valid bootstrap markup. See checkboxes and radios for appropriate markup.
  • The inventory list should use ui-router and states for create/update.
  • The Print button does not update itself when new items are added (old report is printed).
  • All buttons should be btn and not btn-sm.
  • Creating an item should produce an "item receipt" - something like an item fact sheet. This is a bit of an advanced feature.
@jniles jniles added this to the Inventory Management Implementation milestone Sep 23, 2016
jniles pushed a commit to jniles/bhima that referenced this issue Jan 2, 2017
fix(inventory): pass uuids in URL
7298b06 
This commit fixes the inventory server UPDATE route to conform to our
HTTP API standards.  It sends back a JSON object instead of an array,
allowing both the create() and update() routes to pass the uuid back to
the central list state and use the grid to scroll to the updated record.

This commit contains much performance refactoring.
  1. Makes the <select>s use track by in the ActionForm.
  2. Uses <translate> directive instead of filter
  3. Uses a loading indicator on the bhLoadingButton

A few of the issues in
IMA-WorldHealth#738
have been addressed.
jniles pushed a commit to jniles/bhima that referenced this issue Jan 4, 2017
fix(inventory): pass uuids in URL
00203fd 
This commit fixes the inventory server UPDATE route to conform to our
HTTP API standards.  It sends back a JSON object instead of an array,
allowing both the create() and update() routes to pass the uuid back to
the central list state and use the grid to scroll to the updated record.

This commit contains much performance refactoring.
  1. Makes the <select>s use track by in the ActionForm.
  2. Uses <translate> directive instead of filter
  3. Uses a loading indicator on the bhLoadingButton

A few of the issues in
IMA-WorldHealth#738
have been addressed.
jniles pushed a commit to jniles/bhima that referenced this issue Jan 4, 2017
fix(inventory): pass uuids in URL
d87aa02 
This commit fixes the inventory server UPDATE route to conform to our
HTTP API standards.  It sends back a JSON object instead of an array,
allowing both the create() and update() routes to pass the uuid back to
the central list state and use the grid to scroll to the updated record.

This commit contains much performance refactoring.
  1. Makes the <select>s use track by in the ActionForm.
  2. Uses <translate> directive instead of filter
  3. Uses a loading indicator on the bhLoadingButton

A few of the issues in
IMA-WorldHealth#738
have been addressed.
jniles pushed a commit to jniles/bhima that referenced this issue Jan 4, 2017
fix(inventory): pass uuids in URL
d0e532f 
This commit fixes the inventory server UPDATE route to conform to our
HTTP API standards.  It sends back a JSON object instead of an array,
allowing both the create() and update() routes to pass the uuid back to
the central list state and use the grid to scroll to the updated record.

This commit contains much performance refactoring.
  1. Makes the <select>s use track by in the ActionForm.
  2. Uses <translate> directive instead of filter
  3. Uses a loading indicator on the bhLoadingButton

A few of the issues in
IMA-WorldHealth#738
have been addressed.
@jniles jniles added this to Backlog in Inventory Management Feb 10, 2017
@jniles
Copy link
Contributor Author

jniles commented Sep 25, 2017

Closing this as out of date.

@jniles jniles closed this as completed Sep 25, 2017
@jniles jniles moved this from Backlog to Completed in Inventory Management Sep 26, 2017
@jniles jniles removed this from Completed in Inventory Management Sep 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Refactor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jniles