feat(location modal): "add a location" modal #136
Conversation
jniles
force-pushed
the
modal-add-location
branch
3 times, most recently
from
a8fc3aa
to
ccf72bd
Compare
| noData; | ||
| }); | ||
| function loadCountries() { | ||
| Locations.countries() |
There was a problem hiding this comment.
countries() does not express an http action, you should choose a better name as `loadCountries()orgetConuntries()``
There was a problem hiding this comment.
This API was introduced in a previous pull request that created the LocationService. I was using the same syntax as the PatientService, which allows the developer to do Patients.groups() to get the groups associated with a patient. See here.
I'm happy to update particular query if it seems better. Curious about what @sfount thinks.
There was a problem hiding this comment.
I think we discussed this before when discussing previous APIs - in my opinion the angular service abstracts away from the actual HTTP action and does need to directly reflect this in the method name - location.countries makes it clear what will be returned by this method.
That being said I can see nothing truly wrong with either suggestion - we should choose one and try to use a similar naming strategy throughout the application.
There was a problem hiding this comment.
Thanks for the feedback.
I'm happy to change the LocationService API. However, since this is an API change, it will break the bhLocationSelect component and any other modules/services that use the LocationService (I'm not aware of any).
Furthermore, this change is not for code introduced in this PR (the API was developed and introduced in this commit two weeks ago), I propose that a separate pull request change the service API, update the bhLocationSelect component and any tests that are needing to be updated should be addressed then. If we try to include all these changes in this PR, the original purpose will be lost.
jniles
force-pushed
the
modal-add-location
branch
from
ccf72bd
to
3460cbc
Compare
This commit implements the scaffolding for an add location modal. The goal is to be able to add any type of location easily and quickly to the bhima database using a modal interface. There is a link between the location select component and the modal for easy opening/closing. TODO - make the link optional in the component options.
This commit implements INSERT/POST routes for the /locations interface and includes (failing) integration tests for them. The tests will fail until #125 is addressed.
This commit changes the country schema and updates the database schema to store only the required information about locations. Closes #125.
This removes legacy exchange rate code.
This commit improve the location modal by allowing the current view to be stored in appcache. It also cleans up the HTML considerably by employing suggestions made by @sfount.
This commit finishes the complete feature set of the "add location" modal controller and behavior. There should only be bug fixes for a little while. Functionality added: 1. AppCache dynamically caches the view so that everytime the modal is opened, it opens to the previous view. 2. The view clears previous selections when it changes to ensure that we get nicely rendered inputs. 3. English translations have been added. In a further improvement, both bhLocationSelect and this modal use the same keys for their default <select> options, stored in LocationService.messages. This includes messages for no data. 4. The modal now returns the appropriate promise to the controller. Users can now easily add locations instead of navigating away from previous pages and losing their work.
This commit implements e2e tests for the "add location" modal component. These tests can be (and should be) improved over time.
This commit adds a generic error message to the form for better UX.
jniles
force-pushed
the
modal-add-location
branch
from
3460cbc
to
4118584
Compare
|
This PR has been updated with feedback given from @DedrickEnc. |
feat(location modal): "add a location" modal
This commit fixes the voucher identifiers that were broken in the update from the previous updates. Fixes #136.
This commit fixes the voucher identifiers that were broken in the update from the previous updates. Fixes #136.
This PR adds a modal for creating locations on the fly. The modal can create countries, provinces, sectors, or villages. It also improves the translation and code of the
bhLocationSelectcomponent slightly.UI/UX
Default Interface
Selecting a Country
Create a Village Pane
Creating a Village
Error State
No Data State
Overview
This feature allows users to quickly create new location without having to navigate away from the present page. This is particularly useful on the patient registration page. There are four panes, allowing the user to create a new country, province, sector, or village.
The current view is stored in AppCache so that it is recalled whenever the user opens the modal again. In order to create a village, you must choose a country, province, and sector. If those do not exist, the user is alerted and he/she may choose to create the necessary dependencies on their respective panes.
Usage
If you would like to use this modal in your controller, simply import the
LocationServiceand attach themodal()method to an ng-click directive.Tests
A suite of end-to-end tests are found in the file
test/e2e/locations/modal.spec.js. The patient registration page is used as the test bed for this feature.Closes #100.