fix(stock): improve movements registry #2074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jniles
force-pushed
the
fix-stock-reason-search-parameter
branch
3 times, most recently
from
f2ec4e8
to
108c4d1
Compare
|
@jniles |
This commit fixes a number of bugs on the movements registry. 1. The input/output search parameter now actually filters correctly. 2. The "reason" ui-select actually filters the registry. 3. The "actions" column does not present a dropdown on header rows. 4. The date and unit cost columns sort properly. 5. The grid footer no longer gives untranslated english text in the footer. It also improves the performance of the registry by pre-computing costs in the same way that it pre-computes the flux mappings. Closes IMA-WorldHealth#2073. Closes IMA-WorldHealth#2072.
jniles
force-pushed
the
fix-stock-reason-search-parameter
branch
from
108c4d1
to
b4af85d
Compare
|
@DedrickEnc, done. |
DedrickEnc
approved these changes
Sep 4, 2017
| <span translate>STOCK.INPUT</span> | ||
| </label> | ||
| </div> | ||
| <div class="radio"> | ||
| <label> | ||
| <input type="radio" name="is_exit" value="0" ng-model="$ctrl.searchQueries.is_exit"> | ||
| <input type="radio" name="is_exit" value="1" ng-model="$ctrl.searchQueries.is_exit"> |
| <ui-select name="inventory" ng-model="$ctrl.searchQueries.flux_id"> | ||
| <ui-select-match> | ||
| <span translate>{{$select.selected.label}}</span> | ||
| </ui-select-match> | ||
| <ui-select-choices ui-select-focus-patch repeat="flux as flux in $ctrl.fluxes | filter:{ 'label': $select.search }"> | ||
| <ui-select-choices ui-select-focus-patch repeat="flux.id as flux in $ctrl.fluxes | filter:{ 'label': $select.search }"> |
| @@ -1,4 +1,4 @@ | |||
| <div class="ui-grid-cell-contents text-action" uib-dropdown dropdown-append-to-body uib-dropdown-toggle> | |||
| <div class="ui-grid-cell-contents text-action" uib-dropdown dropdown-append-to-body uib-dropdown-toggle ng-if="!row.groupHeader"> | |||
There was a problem hiding this comment.
As you suggested in the email, this enhancement should be done in every registry with grouping option. So an issue should be better.
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Sep 4, 2017
2074: fix(stock): improve movements registry r=DedrickEnc a=jniles This commit fixes a number of bugs on the movements registry. 1. The input/output search parameter now actually filters correctly. 2. The "reason" ui-select actually filters the registry. 3. The "actions" column does not present a dropdown on header rows. 4. The date and unit cost columns sort properly. 5. The grid footer no longer gives untranslated english text in the footer. It also improves the performance of the registry by pre-computing costs in the same way that it pre-computes the flux mappings. Closes #2073. Closes #2072. ---
Build failed |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Sep 5, 2017
2074: fix(stock): improve movements registry r=jniles a=jniles This commit fixes a number of bugs on the movements registry. 1. The input/output search parameter now actually filters correctly. 2. The "reason" ui-select actually filters the registry. 3. The "actions" column does not present a dropdown on header rows. 4. The date and unit cost columns sort properly. 5. The grid footer no longer gives untranslated english text in the footer. It also improves the performance of the registry by pre-computing costs in the same way that it pre-computes the flux mappings. Closes #2073. Closes #2072. ---
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a number of bugs on the movements registry.
footer.
It also improves the performance of the registry by pre-computing costs
in the same way that it pre-computes the flux mappings.
Closes #2073. Closes #2072.
Thank you for contributing!
Before submitting this pull request, please verify that you have:
For a more detailed checklist, see the online review checklist that this PR will be evaluated against.
Ensuring that the above checkboxes are completed will help speed the review process and help build a stronger application. Thanks!