Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ref group #213

Merged
merged 5 commits into from
Mar 30, 2016
Merged

Ref group #213

merged 5 commits into from
Mar 30, 2016

Conversation

lomamech
Copy link
Contributor

  • Reference group API test and Integration Test
  • Resolve Conflict with branch Master in data.sql
  • Improve invalidation form

@sfount @DedrickEnc

sfount
sfount reviewed Mar 30, 2016
View reviewed changes
server/controllers/finance/referenceGroup.js
return db.exec(sql, id)
.then(function (rows) {
if (rows.length === 0) {
throw new codes.ERR_NOT_FOUND();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This method of throwing errors is difficult to understand when reading code. (Where did codes come from and how is it different from id?).

This is perfectly valid for how we used to handle server errors however there was been an important update
#182 was resolved with #208

We can now use:

var NotFound = require('lib/errors/NotFound');
...
throw new NotFound('The entity was not found');

This is much clearer to read and gives additional benefits like stack traces.

@sfount
Copy link
Contributor

sfount commented Mar 30, 2016

@lomamech Please review the way that codes are thrown on the server with this feature and in #203.

The templates could also be cleaned up (removing unnescisary <p> tags) - otherwise this is excellent work.

These re-factors can be submitted as a refactor pull request. (GitHub Tag)

@sfount sfount merged commit 1c45a67 into IMA-WorldHealth:master Mar 30, 2016
jniles referenced this pull request in jniles/bhima Jan 30, 2017
@jniles
Merge pull request #213 from lomamech/formTurnOff
c271664 
Make form input element turn Off
@lomamech lomamech deleted the refGroup branch May 15, 2017 12:14
bors bot added a commit that referenced this pull request Jul 23, 2017
@bors
Merge #1888
7207cda 
1888: Update gulp-rev to the latest version 🚀 r=jniles


## Version **8.0.0** of [gulp-rev](https://github.com/sindresorhus/gulp-rev) just got published.

<table>
  <tr>
    <th align=left>
      Dependency
    </td>
    <td>
      gulp-rev
    </td>
  </tr>
  <tr>
    <th align=left>
      Current Version
    </td>
    <td>
      7.1.2
    </td>
  </tr>
  <tr>
    <th align=left>
      Type
    </td>
    <td>
      devDependency
    </td>
  </tr>
</table>

The version **8.0.0** is **not covered** by your **current version range**.

Without accepting this pull request your project will work just like it did before. There might be a bunch of new features, fixes and perf improvements that the maintainers worked on for you though.

I recommend you look into these changes and try to get onto the latest version of gulp-rev.
Given that you have a decent test suite, a passing build is a strong indicator that you can take advantage of these changes by merging the proposed change into your project. Otherwise this branch is a great starting point for you to work on the update.


---


<details>
<summary>Commits</summary>
<p>The new version differs by 13 commits.</p>
<ul>
<li><a href="https://urls.greenkeeper.io/sindresorhus/gulp-rev/commit/898dffcd9f9d5088895182de543b08b3e83040b3"><code>898dffc</code></a> <code>8.0.0</code></li>
<li><a href="https://urls.greenkeeper.io/sindresorhus/gulp-rev/commit/d290ff82d263048416582a0b220046815d17c05e"><code>d290ff8</code></a> <code>Meta tweaks</code></li>
<li><a href="https://urls.greenkeeper.io/sindresorhus/gulp-rev/commit/a89f0dff0f4ca3782640ec81ad1c1785d07b2be8"><code>a89f0df</code></a> <code>Make tests independent of platform specific path separator (#219) (#221)</code></li>
<li><a href="https://urls.greenkeeper.io/sindresorhus/gulp-rev/commit/71a0377821e310b437159eb6909a93d02ddf49c6"><code>71a0377</code></a> <code>Add a note about non-deterministic streams order (#213)</code></li>
<li><a href="https://urls.greenkeeper.io/sindresorhus/gulp-rev/commit/f5ee9ee2419ae3979c083ac7cadd1208a2cdddc0"><code>f5ee9ee</code></a> <code>Meta tweaks</code></li>
<li><a href="https://urls.greenkeeper.io/sindresorhus/gulp-rev/commit/731be706d08ab78fa75bffdaeedcd303a6692890"><code>731be70</code></a> <code>Move list of maintainers into the readme for visibility</code></li>
<li><a href="https://urls.greenkeeper.io/sindresorhus/gulp-rev/commit/192a0753ca509b7acf622165a02227889b56b714"><code>192a075</code></a> <code>Meta tweaks</code></li>
<li><a href="https://urls.greenkeeper.io/sindresorhus/gulp-rev/commit/7acdb13e7f079fce816320547de11793f01ed625"><code>7acdb13</code></a> <code>Move tests from Mocha to AVA (#212)</code></li>
<li><a href="https://urls.greenkeeper.io/sindresorhus/gulp-rev/commit/82c185cbe9ef6a421365bc1120a0eeefdc787d3e"><code>82c185c</code></a> <code>More realistic example (#203)</code></li>
<li><a href="https://urls.greenkeeper.io/sindresorhus/gulp-rev/commit/02fbeba48364118d3886decb39359102689608ea"><code>02fbeba</code></a> <code>add XO badge</code></li>
<li><a href="https://urls.greenkeeper.io/sindresorhus/gulp-rev/commit/8686e62b380a22976f314687bd3f79ca69cae24f"><code>8686e62</code></a> <code>[breaking] ES2015ify and require Node.js 4</code></li>
<li><a href="https://urls.greenkeeper.io/sindresorhus/gulp-rev/commit/ed53cefc8486ce95e9a5f5d837ddaf0ce16e2ad8"><code>ed53cef</code></a> <code>meta tweaks</code></li>
<li><a href="https://urls.greenkeeper.io/sindresorhus/gulp-rev/commit/17d6bb42525f46dd6ff60fa56d45be86c15152a3"><code>17d6bb4</code></a> <code>docs: change number of approaches (#196)</code></li>
</ul>
<p>See the <a href="https://urls.greenkeeper.io/sindresorhus/gulp-rev/compare/e895123b92f4a39fcf6a3f37dbdd78bc6f93c0c5...898dffcd9f9d5088895182de543b08b3e83040b3">full diff</a></p>
</details>

<details>
  <summary>Not sure how things should work exactly?</summary>

  There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html) and of course you may always [ask my humans](https://github.com/greenkeeperio/greenkeeper/issues/new).
</details>


---


Your [Greenkeeper](https://greenkeeper.io) Bot 🌴
bors bot added a commit that referenced this pull request Jul 26, 2018
@bors @greenkeeper
Merge #2970
5c0df88 
2970: Update mailgun-js to the latest version 🚀 r=jniles a=greenkeeper[bot]




## Version **0.20.0** of **mailgun-js** was just published.

<table>
  <tr>
    <th align=left>
      Dependency
    </th>
    <td>
      <a target=_blank href=https://github.com/bojand/mailgun-js>mailgun-js</a>
    </td>
  </tr>
  <tr>
      <th align=left>
       Current Version
      </th>
      <td>
        0.19.0
      </td>
    </tr>
  <tr>
    <th align=left>
      Type
    </th>
    <td>
      dependency
    </td>
  </tr>
</table>



The version **0.20.0** is **not covered** by your **current version range**.

If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.

It might be worth looking into these changes and trying to get this project onto the latest version of mailgun-js.

If you have a solid test suite and good coverage, a passing build is a strong indicator that you can take advantage of these changes directly by merging the proposed change into your project. If the build fails or you don’t have such unconditional trust in your tests, this branch is a great starting point for you to work on the update.


---


<details>
<summary>Commits</summary>
<p>The new version differs by 3 commits.</p>
<ul>
<li><a href="https://urls.greenkeeper.io/bojand/mailgun-js/commit/f8b0e41f69660114411d5b1844fd2194f53032ce"><code>f8b0e41</code></a> <code>0.20.0</code></li>
<li><a href="https://urls.greenkeeper.io/bojand/mailgun-js/commit/a707acb7996b23498fcc77b42e3c9ef26bc4c9b1"><code>a707acb</code></a> <code>Merge pull request #213 from Donky-Network/relax-attachment-validation</code></li>
<li><a href="https://urls.greenkeeper.io/bojand/mailgun-js/commit/d43b32e4af33ff6fe1061155c0a9b7161c55ee74"><code>d43b32e</code></a> <code>Relaxed validation around stream attachments, allowing a filename to be specified</code></li>
</ul>
<p>See the <a href="https://urls.greenkeeper.io/bojand/mailgun-js/compare/8b78344104771204d655c12c77c89c6c182f4498...f8b0e41f69660114411d5b1844fd2194f53032ce">full diff</a></p>
</details>

<details>
  <summary>FAQ and help</summary>

  There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new).
</details>

---


Your [Greenkeeper](https://greenkeeper.io) bot 🌴



Co-authored-by: greenkeeper[bot] <greenkeeper[bot]@users.noreply.github.com>
bors bot added a commit that referenced this pull request Sep 9, 2018
@bors @greenkeeper
Merge #3166
a58746a 
3166: Update snyk to the latest version 🚀 r=jniles a=greenkeeper[bot]




## Version **1.95.1** of **snyk** was just published.

<table>
  <tr>
    <th align=left>
      Dependency
    </th>
    <td>
      <a target=_blank href=https://github.com/snyk/snyk>snyk</a>
    </td>
  </tr>
  <tr>
      <th align=left>
       Current Version
      </th>
      <td>
        1.95.0
      </td>
    </tr>
  <tr>
    <th align=left>
      Type
    </th>
    <td>
      dependency
    </td>
  </tr>
</table>



The version **1.95.1** is **not covered** by your **current version range**.

If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.

It might be worth looking into these changes and trying to get this project onto the latest version of snyk.

If you have a solid test suite and good coverage, a passing build is a strong indicator that you can take advantage of these changes directly by merging the proposed change into your project. If the build fails or you don’t have such unconditional trust in your tests, this branch is a great starting point for you to work on the update.


---


<details>
<summary>Release Notes</summary>
<strong>v1.95.1</strong>

<h2><a href="https://urls.greenkeeper.io/snyk/snyk/compare/v1.95.0...v1.95.1">1.95.1</a> (2018-09-09)</h2>
<h3>Bug Fixes</h3>
<ul>
<li>bump mvn,gradle and sbt plugins for better error handling (<a href="https://urls.greenkeeper.io/snyk/snyk/commit/34dc3a6">34dc3a6</a>)</li>
</ul>
</details>

<details>
<summary>Commits</summary>
<p>The new version differs by 2 commits.</p>
<ul>
<li><a href="https://urls.greenkeeper.io/snyk/snyk/commit/f65072913187d8e34d6fb9ceaae1f7dc576cef39"><code>f650729</code></a> <code>Merge pull request #213 from snyk/fix/bump-plugins</code></li>
<li><a href="https://urls.greenkeeper.io/snyk/snyk/commit/34dc3a63a7d0304e3f4fdd1e2b6ac6f6fd13817a"><code>34dc3a6</code></a> <code>fix: bump mvn,gradle and sbt plugins for better error handling</code></li>
</ul>
<p>See the <a href="https://urls.greenkeeper.io/snyk/snyk/compare/d9304ee08c699cd937fb5d3364a71830339905e0...f65072913187d8e34d6fb9ceaae1f7dc576cef39">full diff</a></p>
</details>

<details>
  <summary>FAQ and help</summary>

  There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new).
</details>

---


Your [Greenkeeper](https://greenkeeper.io) bot 🌴



Co-authored-by: greenkeeper[bot] <greenkeeper[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lomamech @sfount