chore(vouchers): lint toolkit and reduce code #3527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit refactors the voucher toolkits through linting the JS code. I've also used the bh-cashbox-select on the convention payment page to reduce the overall size of the file.
jniles
force-pushed
the
chore-clean-up-voucher-tool-kit
branch
from
96cef4c
to
e403492
Compare
|
@lomamech or @jeremielodi , can I get a review? |
|
Looks like the internet crisis is limiting abilities to review. bors r+ |
bors bot
added a commit
that referenced
this pull request
Jan 15, 2019
3527: chore(vouchers): lint toolkit and reduce code r=jniles a=jniles This commit refactors the voucher toolkits through linting the JS code. I've also used the bh-cashbox-select on the convention payment page to reduce the overall size of the file. Co-authored-by: Jonathan Niles <jonathanwniles@gmail.com>
Build failed |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Jan 21, 2019
3527: chore(vouchers): lint toolkit and reduce code r=jniles a=jniles This commit refactors the voucher toolkits through linting the JS code. I've also used the bh-cashbox-select on the convention payment page to reduce the overall size of the file. Co-authored-by: Jonathan Niles <jonathanwniles@gmail.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit refactors the voucher toolkits through linting the JS code. I've also used the bh-cashbox-select on the convention payment page to reduce the overall size of the file.