Improve the appearance of boolean search filter flags #5859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmcameron
force-pushed
the
fix_search_flag_tags
branch
from
6bcd345
to
2f4ddab
Compare
|
LGTM 👍🏽 bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements an improvement in the presentation of the boolean search flags in various registries to make them more user-friendly. The boolean flags now show "Yes"/"Oui" for 1 and "No"/"Non" for 0.
Closes #5803
For example, notice the circled flags in the stock lots registry:
To make a filter definition work this way, add this to its definition:
..., valueFilter : 'boolean'.
This change affects the search flag displays for the following registries.
I attempted to update as many of these boolean filter flags as possible, but I'm sure I missed some.