Use of decimal for stock minimum months #5877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o use-of-decimal-for-stock-minimum-months
jmcameron
requested changes
Aug 24, 2021
| @@ -129,8 +129,7 @@ | |||
| FORM.LABELS.MIN_MONTHS_SECURITY_STOCK | |||
| </label> | |||
| <input name="min_months_security_stock" class="form-control" | |||
| ng-model="DepotModalCtrl.depot.min_months_security_stock" type="number" min="1" autocomplete="off" required | |||
| bh-integer> | |||
| ng-model="DepotModalCtrl.depot.min_months_security_stock" type="number" min="0" autocomplete="off" required> | |||
There was a problem hiding this comment.
We should consider making min="0.00001" (or similar) to prevent acceptance of zero.
|
bors try |
tryBuild succeeded: |
jmcameron
reviewed
Aug 26, 2021
There was a problem hiding this comment.
The code changes look good (see my notes).
I tested this with bhima_test. Changing the values in stock settings works fine.
However when I tried it with the Depot editor, it seems like the values are set properly, but when I edit again, I see that the value "Default Purchase order interval (in months)" is still 0 (I set it to 0.25). See:
jniles
reviewed
Aug 26, 2021
server/models/schema.sql
Outdated
| @@ -461,7 +461,7 @@ CREATE TABLE `depot` ( | |||
| `allow_exit_transfer` TINYINT(1) UNSIGNED NOT NULL DEFAULT 0, | |||
| `allow_exit_loss` TINYINT(1) UNSIGNED NOT NULL DEFAULT 0, | |||
| `location_uuid` BINARY(16) NULL, | |||
| `min_months_security_stock` SMALLINT(5) NOT NULL DEFAULT 2, | |||
| `min_months_security_stock` DECIMAL(19,4) NOT NULL DEFAULT 2, | |||
| `parent_uuid` BINARY(16) NULL, | |||
| `dhis2_uid` VARCHAR(150) DEFAULT NULL, | |||
| `default_purchase_interval` SMALLINT(5) NOT NULL DEFAULT 0, | |||
There was a problem hiding this comment.
This needs to be DECIMAL as well. That is the problem @jmcameron ran into.
There was a problem hiding this comment.
I had done changes only in migrate.js
jniles
approved these changes
Aug 31, 2021
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to #5876
Close #5876