Feat: add aggregate cost center table #5885

jniles · 2021-08-26T12:48:32Z

This PR adds the back-end tables for aggregating costs by cost center and the stored procedure for generating it. It should serve as a reference for how to create the table for step-down analysis.

Closes #5880.
Closes #5881.

lomamech

I will add other comments during the Pull Request test

lomamech · 2021-08-30T09:58:49Z

server/models/schema.sql

@@ -2561,4 +2573,20 @@ CREATE TABLE `configuration_analysis_tools` (
  CONSTRAINT `config_analysis_tools__analysis_tool_type` FOREIGN KEY (`analysis_tool_type_id`) REFERENCES `analysis_tool_type` (`id`)
 ) ENGINE=InnoDB DEFAULT CHARACTER SET = utf8mb4 DEFAULT COLLATE = utf8mb4_unicode_ci;

+
+DROP TABLE IF EXISTS `cost_center_aggregate`;


Will it be possible to rename this table fee_center_aggregate or cost_profit_center_aggregate, Just because this way it will make it look like this table is not about profit centers

I was implementing the proposal from #5861. I think in English, all off the fee centers are called cost centers. But I could be wrong.

@jmcameron has read more of the documentation than i have. @jmcameron do you have a thought on what the best name is?

Let's wait for his feedback

@jmcameron has read more of the documentation than i have. @jmcameron do you have a thought on what the best name is?

I suggest "Cost Centers" for all services and cost/profit centers. In a sense this is appropriate: All services or centers have costs. Some centers can generate revenue. These are usually also called revenue centers. But they are still cost centers. Regarding the "Adminstration" center at IMCK: This should probably be split up into a Registration Service which could be treated as revenue center. But Administration is normally a cost center NOT a revenue center.

The term "Cost Center" is not explicitly used in the "Essentials of Healthcare Finance" book (we have its chapter 13). But "Cost Center" is used in the "Annex B" handbook. AND "Cost Center" is used in the list of things Larry wants us to do. So he uses this terminology. So I encourage us to use "Cost Center" as the general term for all services/cost/profit/revenue centers.

Centre de frais = Cost Center

lomamech · 2021-08-30T10:02:26Z

server/models/schema.sql

@@ -1315,6 +1323,8 @@ CREATE TABLE `posting_journal` (
  KEY `period_id` (`period_id`),
  KEY `currency_id` (`currency_id`),
  KEY `user_id` (`user_id`),
+  KEY `cost_center_id` (`cost_center_id`),


Will it be possible to rename this property fee_center_id or cost_profit_center_id

lomamech · 2021-08-30T10:48:09Z

@jniles You forgot to put the changes in the migrate.sql file

This commit adds the cost_center_id and principal_center_id to the financial tables in the database. Closes IMA-WorldHealth#5880.

jniles · 2021-08-30T11:14:49Z

@lomamech @jmcameron changes landed.

lomamech · 2021-08-30T11:53:53Z

After entering the cost centers manually, calling the function works fine

lomamech · 2021-08-30T11:56:03Z

@jmcameron what do you think of this PR i think we can merge it up

jmcameron

I wonder whether this is a good time to rename the 'fee_center" table to 'cost_center'? It will only get more complicated as we add functionality?

jmcameron · 2021-08-30T15:11:22Z

server/models/migrations/next/migrate.sql

+) ENGINE=InnoDB DEFAULT CHARACTER SET = utf8mb4 DEFAULT COLLATE = utf8mb4_unicode_ci;
+
+
+ALTER TABLE `posting_journal` ADD COLUMN `cost_center_id`      MEDIUMINT(8) UNSIGNED NULL;


I suggest you use the add_column_if_missing() function to add these new columns

Whoops, good point.

server/models/schema.sql

Adds the admin SQL procedures to create the cost_center_aggregates table. Closes IMA-WorldHealth#5881.

jniles · 2021-08-31T07:57:26Z

@jmcameron changes landed. I tested these on the vanga database.

For the renaming of the fee_center, let's get this one in first and then I'll work on renaming the fee center table. I think that may take a lot longer than this.

jmcameron · 2021-08-31T08:19:31Z

For the renaming of the fee_center, let's get this one in first and then I'll work on renaming the fee center table. I think that may take a lot longer than this.

Sounds good.

jmcameron

Looks good.

One question (not a blocker): Can 'IGNORE' be used with the ADD CONSTRAINT lines in the migrate.sql file (so it can be loaded more than once). I see that we have an SQL function Constraint_exists() so it would not be hard to create a function like add_column_if_missing() function for constraints.

jniles · 2021-08-31T08:47:37Z

There is no IGNORE for ALTER TABLE that I can tell: https://dev.mysql.com/doc/refman/8.0/en/alter-table.html

This would therefore need to be a custom stored procedure. I'll make an issue.

jniles added the Cost Centers label Aug 26, 2021

jniles requested review from lomamech and jmcameron August 26, 2021 12:48

lomamech reviewed Aug 30, 2021

View reviewed changes

feat(schema): add cost centers to financial tables

bba0484

This commit adds the cost_center_id and principal_center_id to the financial tables in the database. Closes IMA-WorldHealth#5880.

jniles force-pushed the feat-add-aggregate-cost-center-table branch from 57067fa to b96c33d Compare August 30, 2021 11:14

jmcameron reviewed Aug 30, 2021

View reviewed changes

feat(schema): add cost_center_aggregates creation

af4987c

Adds the admin SQL procedures to create the cost_center_aggregates table. Closes IMA-WorldHealth#5881.

jniles force-pushed the feat-add-aggregate-cost-center-table branch from b96c33d to af4987c Compare August 31, 2021 07:56

jmcameron approved these changes Aug 31, 2021

View reviewed changes

jniles mentioned this pull request Aug 31, 2021

Add a "add_constraint_if_missing()" stored procedure to easy migrations #5893

Closed

jniles merged commit a78c5ed into IMA-WorldHealth:master Aug 31, 2021

jniles deleted the feat-add-aggregate-cost-center-table branch August 31, 2021 11:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat: add aggregate cost center table #5885

Feat: add aggregate cost center table #5885

jniles commented Aug 26, 2021

lomamech left a comment

lomamech Aug 30, 2021

jniles Aug 30, 2021

lomamech Aug 30, 2021

jmcameron Aug 30, 2021

lomamech Aug 30, 2021

lomamech Aug 30, 2021

lomamech commented Aug 30, 2021

jniles commented Aug 30, 2021

lomamech commented Aug 30, 2021

lomamech commented Aug 30, 2021

jmcameron left a comment

jmcameron Aug 30, 2021

jniles Aug 31, 2021

jniles commented Aug 31, 2021

jmcameron commented Aug 31, 2021

jmcameron left a comment

jniles commented Aug 31, 2021

		) ENGINE=InnoDB DEFAULT CHARACTER SET = utf8mb4 DEFAULT COLLATE = utf8mb4_unicode_ci;


		ALTER TABLE `posting_journal` ADD COLUMN `cost_center_id` MEDIUMINT(8) UNSIGNED NULL;

Feat: add aggregate cost center table #5885

Feat: add aggregate cost center table #5885

Conversation

jniles commented Aug 26, 2021

lomamech left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lomamech commented Aug 30, 2021

jniles commented Aug 30, 2021

lomamech commented Aug 30, 2021

lomamech commented Aug 30, 2021

jmcameron left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jniles commented Aug 31, 2021

jmcameron commented Aug 31, 2021

jmcameron left a comment

Choose a reason for hiding this comment

jniles commented Aug 31, 2021